Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Message-ID: <1090675129.1136400901754.JavaMail.jira@ajax.apache.org>
Date: Wed, 4 Jan 2006 19:55:01 +0100 (CET)
From: "Rick Hillegas (JIRA)" <derby-dev@db.apache.org>
To: derby-dev@db.apache.org
Subject: [jira] Commented: (DERBY-768) Build doesnt fail inspite of presence
 of a bug in JDBC4.0 specific classes  and setting proceed=false
In-Reply-To: <88594995.1134726465706.JavaMail.jira@ajax.apache.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

    [ http://issues.apache.org/jira/browse/DERBY-768?page=comments#action_12361779 ] 

Rick Hillegas commented on DERBY-768:
-------------------------------------

I'm afraid this patch does not seem to fix the problem, at least when run on my environment: cygwin under XP. I ran the following experiments:

A) I inserted garbage into an engine class (AggregateNode.java) and then ran "ant -quiet all".

B) Then I removed those edits, did an "ant -quiet clean", inserted garbage into a JDBC 4.0 class (CallableStatement40.java), and ran "ant -quiet all"

In experiment (A), I saw compiler errors and the build terminated after stumbling on the garbage.

In experiment (B), however, I did not see any compiler errors (just an indication that some error had occurred). In addition, the compilation continued after stumbling on the garbage. Here is the output from experiment (B):

     [echo] Ant environment:
     [echo]   Base Directory: C:\cygwin\home\rh161140\derby\mainline\trunk
     [echo]   Build output: C:\cygwin\home\rh161140\derby\mainline\trunk/classes
     [echo]   Compiler: modern
     [echo]   Sane = true
     [echo]   Proceed = no

     [echo]   Generating SanityState.java...
     [echo]   Generating ij parser...
     [java] Warning: Lookahead adequacy checking not being performed since option LOOKAHEAD is more than 1.  Set option
FORCE_LA_CHECK to true to force checking.
     [echo]   Generating mtGrammar parser...
     [echo]   Generating SQL parser...
     [java] Warning: ParseException.java: File is obsolete.  Please rename or delete this file so that a new one can be
generated for you.
     [java] Warning: Token.java: File is obsolete.  Please rename or delete this file so that a new one can be generated
 for you.
     [java] Warning: CharStream.java: File is obsolete.  Please rename or delete this file so that a new one can be gene
rated for you.
    [javac] 2 warnings
    [javac] 1 warning
    [javac] 8 warnings
    [javac] 3 warnings
    [javac] 1 warning
    [javac] 77 warnings

     [exec] BUILD FAILED
     [exec] C:\cygwin\home\rh161140\derby\mainline\trunk\java\client\build.xml:67: Compile failed; see the compiler erro
r output for details.

     [exec] Total time: 1 second
    [javac] 3 warnings
    [javac] 3 warnings
    [javac] 3 warnings

BUILD SUCCESSFUL
Total time: 1 minute 17 seconds

> Build doesnt fail inspite of presence of a bug in JDBC4.0 specific classes  and setting proceed=false
> -----------------------------------------------------------------------------------------------------
>
>          Key: DERBY-768
>          URL: http://issues.apache.org/jira/browse/DERBY-768
>      Project: Derby
>         Type: Bug
>   Components: Build tools
>     Reporter: V.Narayanan
>     Assignee: V.Narayanan
>  Attachments: build.diff
>
> The jdbc4 target does not echo anything about number of files compiled, as does the ordinary compilation. Then, when a bug is inserted in a file (CallableStatement40.java), the build proceeds in spite of setting proceed=false in ant.propeties. The build eventually reports BUILD SUCCEEDED, although the JDBC4 build failed.
> ---------------------------------------- build log snippet:
> compile_jdbc4_target:
>      [exec] Result: 1
>      [echo]     [javac] /home/dw136774/derby/trunk/java/client/org/apache/derby/client/ClientPooledConnection40.java:26: class, interface, or enum expected
>      [echo]     [javac] foobar public class ClientPooledConnection40 extends ClientPooledConnection {
>      [echo]     [javac] ^
>      [echo]     [javac] 1 error
>      [echo] 
>      [echo] BUILD FAILED
>      [echo] /home/dw136774/derby/trunk/java/client/build.xml:67: Compile failed; see the compiler error output for details.
>      [echo] 
>      [echo] Total time: 1 second
> build:
> build_base:
> compile:
> build:
> build:
> ckversioninfo:
> writeversioninfo:
> versioninfo:
> checklocaleinfo:
> localeinfo:
> buildsource:
> demo:
> compile:
> demo:
> testing:
> testing:
> init:
> compile:
> copyfiles:
> FTharness:
> copyfiles:
> testdata:
> copyfiles:
> compile:
> FTpolicy:
> util:
> checkjikessource:
> compilex_gump:
> compilex_nosource:
> compilex:
> FTOtestsubdir:
> compilet1:
> copyfiles:
> FTOtestsubdir:
> compilex:
> compilet2:
> compilet1:
> copyfiles:
> FTOtestsubdir:
> compilet3:
> compilet2:
> compilet1:
> copyfiles:
> FTOtestsubdir:
> compile:
> copyfiles:
> FTOtestsubdir:
> compile:
> copyfiles:
> FTOtestsubdir:
> compilet2:
> compilet1:
> copyfiles:
> FTOtestsubdir:
> copyfiles:
> FTOtestsubdir:
> compile:
> FTOtestsubdir:
> compilet2:
> compilet1:
> copyfiles:
> FTOtestsubdir:
> copyfiles:
> FTOtestsubdir:
> compile:
> copyfiles:
> FTOtestsubdir:
> compilet1:
> copyfiles:
> FTOtestsubdir:
> copyfiles:
> FTstress:
> copyfiles:
> FTmaster:
> copyfiles:
> suites:
> compile_jdbc4_target:
>      [echo] BUILD SUCCESSFUL
>      [echo] Total time: 1 second
> all:
> BUILD SUCCESSFUL
> Total time: 34 seconds

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira