db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel John Debrunner <...@apache.org>
Subject Re: [jira] Updated: (DERBY-125) Network Server can send DSS greater than 32K to client, which breaks DRDA protocol.
Date Tue, 10 Jan 2006 14:13:37 GMT
Bryan Pendleton wrote:
> Army wrote:
> 
>> Well I'm a day late, but I've finished my review of the patch...
> 
> 
> Hi Army,
> 
> Thank you very much for the careful review and the helpful suggestions.
> There were a number of points in your message, many of which I will
> address when I re-submit the patch proposal, but there were several
> points which are large enough that I'd like to address them specifically
> in this message.
> 
> ---------------
> 
> 1) Should this be one patch or several? It is indeed awkward to
> bundle all these changes together, and they aren't all interdependent.
> For example, DERBY-170 can be easily broken out. Also, the changes to
> DDMWriter.finalizeDSSLength() that I propose for DERBY-125 can certainly
> be separated from the "offset API" changes that I propose for DERBY-491 and
> DERBY-492. I'd like to hear the opinions of others on the list about
> whether
> to break this patch up or not.

Separate focused patches are always better. They are much easier to
understand and to merge or revert should the need arise. It's very
similar to the desire to keep real changes separate from
formatting/cleanup changes.

It would be nice if subversion allowed modified files to be associated
in groups, so that one could develop with multiple changes but keep them
separate during development and submission time. That's one thing I miss
from Perforce which was the codeline mgmt for Cloudscape.

Dan.



Mime
View raw message