db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kristian Waagan <Kristian.Waa...@Sun.COM>
Subject Re: [PATCH] (DERBY-746) NullPointerException when 'encryptionKey' length is an odd number, or it contains invalid chars
Date Wed, 04 Jan 2006 18:51:45 GMT
Sunitha Kambhampati wrote:
> Kristian Waagan wrote:
> 
>> Hello,
>>
>> I just uploaded a patch for DERBY-746 
>> (http://issues.apache.org/jira/browse/DERBY-746). It would be nice if 
>> someone could spare the time to review it so it can be committed soon.
>>
>> The patch fixes the problem of Derby failing with a NPE when the 
>> encryption key specified in the connection URL has either an odd 
>> length or contains invalid characters.
>>
> Thanks Kristian for the patch.  It looks good. There is one minor typo 
> in the english message  -  hexedecimal instead of 'hexadecimal'.

Auch, more proofreading next time... Thanks for catching the spelling 
error :)

> 
> I noticed Dan has committed this patch. Maybe a committer can make this 
> correction instead of needing a separate patch (?)

I have uploaded a new additional patch (derby-746a.diff). It fixes the 
spelling error in the message file and the test master file.
If a committer corrects the error manually, don't forget to fix the 
master file as well!



--
Kristian

> 
> Thanks,
> Sunitha.


Mime
View raw message