db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel John Debrunner (JIRA)" <derby-...@db.apache.org>
Subject [jira] Commented: (DERBY-819) Provide JDBC4 SQLException subclasses support in Embedded driver
Date Thu, 19 Jan 2006 00:56:42 GMT
    [ http://issues.apache.org/jira/browse/DERBY-819?page=comments#action_12363193 ] 

Daniel John Debrunner commented on DERBY-819:
---------------------------------------------

The method Driver40.getJDBC40Exception() can never return null but its caller checks for a
null return. This methodshould probably be in-lined in Driver40.getSQLException.

Can you add  javadoc comments explaining the new methods you have added, comments are a good
thing.

Is there any benefit to the constants you've added in SQLState, such as SQLState.CLASS_PREFIX_SYNTAX_ERROR?
The code in getJDBC40Exception() would be cleaner and match the JDBC 4.0 javadoc if you used
the values directly, like "42". I don't think these constants are going to be used anywhere
else.

This file seems to be left over from the previous patch -  java/engine/org/apache/derby/impl/jdbc/build.xml

Thanks for addressing most of my previous concerns.

> Provide JDBC4 SQLException subclasses support in Embedded driver
> ----------------------------------------------------------------
>
>          Key: DERBY-819
>          URL: http://issues.apache.org/jira/browse/DERBY-819
>      Project: Derby
>         Type: Sub-task
>   Components: JDBC
>  Environment: all
>     Reporter: Anurag Shekhar
>     Assignee: Anurag Shekhar
>     Priority: Minor
>  Attachments: derby-819.diff, stat.out
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message