Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 82727 invoked from network); 7 Dec 2005 18:17:19 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 7 Dec 2005 18:17:19 -0000 Received: (qmail 95388 invoked by uid 500); 7 Dec 2005 18:17:18 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 95349 invoked by uid 500); 7 Dec 2005 18:17:17 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 95327 invoked by uid 99); 7 Dec 2005 18:17:17 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Dec 2005 10:17:17 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (asf.osuosl.org: local policy) Received: from [32.97.182.142] (HELO e2.ny.us.ibm.com) (32.97.182.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Dec 2005 10:17:16 -0800 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e2.ny.us.ibm.com (8.12.11/8.12.11) with ESMTP id jB7IGtnX029947 for ; Wed, 7 Dec 2005 13:16:55 -0500 Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay04.pok.ibm.com (8.12.10/NCO/VERS6.8) with ESMTP id jB7IGsv0111794 for ; Wed, 7 Dec 2005 13:16:54 -0500 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.12.11/8.13.3) with ESMTP id jB7IGsAY014416 for ; Wed, 7 Dec 2005 13:16:54 -0500 Received: from [127.0.0.1] (DMCSDJDT41P.usca.ibm.com [9.72.133.55]) by d01av03.pok.ibm.com (8.12.11/8.12.11) with ESMTP id jB7IGqB1014290 for ; Wed, 7 Dec 2005 13:16:54 -0500 Message-ID: <43972715.2070307@debrunners.com> Date: Wed, 07 Dec 2005 10:16:53 -0800 From: Daniel John Debrunner User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20040910 X-Accept-Language: de, en-us, en MIME-Version: 1.0 To: derby-dev@db.apache.org Subject: Re: patch to enable the BOOLEAN datatype References: <4395D5DE.40705@sun.com> In-Reply-To: <4395D5DE.40705@sun.com> X-Enigmail-Version: 0.90.0.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Rick Hillegas wrote: > I've clipped to jira 499 a patch enabling the BOOLEAN datatype. In BooleanTest.java, at line 400, and elsewhere you use java.lang.Short as the value to be checked for a SMALLINT type in assertRow. JDBC defines that SMALLINT maps to java.lang.Integer as an object type, thus I wonder if tests should use Integer as well. This would mean that assertRow could potentially check the primitive and object view of a row from ResultSet. I haven't looked to see exactly what it does at the moment. Dan.