db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Knut Anders Hatlen <Knut.Hat...@Sun.COM>
Subject Re: [jira] Commented: (DERBY-733) Starvation in RAFContainer.readPage()
Date Thu, 15 Dec 2005 13:03:44 GMT
> Daniel John Debrunner commented on DERBY-733:
> ---------------------------------------------
> The issue I have with this current patch is that is is localized to
> one use in RAFContainer, when reading files.  Most likely there are
> other locations where such a facility would be useful, especially on
> the write for RAFContainer. Are we going to have similar if (java5)
> statements everywhere. The module api already supports loading
> different code for different environments, I think that this
> functionality could be added to the LockManager or maybe a separate
> module. This would be an improvement, but I think it would be a
> mistake to have similar code to this patch in many areas of
> Derby. And yes, maybe we could work on improving Latch performance
> along these lines.

I agree that if we find other parts of the Derby code that needs this
facility, we should either extend an existing module or create a new
module that provides it. The LockManager is probably the right place
to put it. Since the community seems to be interested in rewriting
much of Derby's I/O system, we could do this as a part of the rewrite.

Knut Anders

View raw message