db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From TomohitoNakayama <tomon...@basil.ocn.ne.jp>
Subject Re: [jira] Commented: (DERBY-326) Improve streaming of large objects for network server and client
Date Fri, 30 Dec 2005 05:25:50 GMT
Hello.

I see.
I didn't noticed there exists formatting change.

I will remove formatting change from the patch using command "svn diff 
--diff-cmd diff -x -uw".

Best regards.

Daniel John Debrunner wrote:

>Bryan Pendleton (JIRA) wrote:
>
>  
>
>>    [ http://issues.apache.org/jira/browse/DERBY-326?page=comments#action_12361391
] 
>>
>>Bryan Pendleton commented on DERBY-326:
>>---------------------------------------
>>
>>It seems as though there are a lot of modified lines in your patch, but many of them
appear to be simply indentation/whitespace changes. Is it possible that you could re-run your
diff command with the whitespace
>>changes excluded? Perhaps something like "svn diff --diff-cmd diff -x -uw"? That would
make the patch
>>easier to read and understand, for me. Thanks, bryan
>>    
>>
>
>Or even better, try to remove the formatting changes from the patch.
>
>Such formatting changes can obsure the real changes on the actual
>commit, it's better to separate formatting changes into different
>patches from actual code changes.
>
>Dan.
>
>
>
>  
>

-- 
/*

        Tomohito Nakayama
        tomonaka@basil.ocn.ne.jp
        tomohito@rose.zero.ad.jp
        tmnk@apache.org

        Naka
        http://www5.ocn.ne.jp/~tomohito/TopPage.html

*/ 


Mime
View raw message