db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel John Debrunner <...@debrunners.com>
Subject Re: [jira] Commented: (DERBY-326) Improve streaming of large objects for network server and client
Date Thu, 29 Dec 2005 18:50:42 GMT
Bryan Pendleton (JIRA) wrote:

>     [ http://issues.apache.org/jira/browse/DERBY-326?page=comments#action_12361391 ]

> 
> Bryan Pendleton commented on DERBY-326:
> ---------------------------------------
> 
> It seems as though there are a lot of modified lines in your patch, but many of them
appear to be simply indentation/whitespace changes. Is it possible that you could re-run your
diff command with the whitespace
> changes excluded? Perhaps something like "svn diff --diff-cmd diff -x -uw"? That would
make the patch
> easier to read and understand, for me. Thanks, bryan

Or even better, try to remove the formatting changes from the patch.

Such formatting changes can obsure the real changes on the actual
commit, it's better to separate formatting changes into different
patches from actual code changes.

Dan.


Mime
View raw message