db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel John Debrunner <...@debrunners.com>
Subject Re: [jira] Commented: (DERBY-333) Malformed if statement in org.apache.derby.impl.drda.Database.getDRDAStatement()
Date Wed, 21 Dec 2005 19:18:23 GMT
Knut Anders Hatlen (JIRA) wrote:

>     [ http://issues.apache.org/jira/browse/DERBY-333?page=comments#action_12361027 ]

> 
> Knut Anders Hatlen commented on DERBY-333:
> ------------------------------------------
> 
> Bryan's proposed rewrite of getDRDAStatement() is a lot clearer than
> the original code, and as far as I can tell, it does the exact same
> thing. I have to change getDRDAStatement() anyway in my work with
> DERBY-212. If no one objects or has better proposals, I will make this
> change in my patch for DERBY-212.

I think that's a good general approach. Make the code cleaner and remove
old cruft that doesn't do anything. It's always in the svn history if
someone needs to bring it back in some form.

Dan.


Mime
View raw message