db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel John Debrunner <...@debrunners.com>
Subject Re: [jira] Commented: (DERBY-649) Useful indexes not used in UNION ALL
Date Tue, 20 Dec 2005 23:57:00 GMT
Satheesh Bandaram wrote:

> Thanks for reviewing the patch.
> 
> Daniel John Debrunner wrote:
> 
>>Satheesh Bandaram (JIRA) wrote:

>>And closely related, in the code (UnionNode.java) you say
>>'For now, we only push simple
>>+	 * single column predicates that are binaryOperations.'
>>
>>Does this need to be clarified? Maybe state explictly what can be pushed
>>down, maybe 'simple' to you, would be 'complex' to me?
>>  
>>
> OK. I will expand the comments on this.
> 
>>Could you explain new the code in pushExpressionsIntoSelect? Since you
>>have spent time on this, it would be great to capture your thoughts in
>>the code comments. For example, why do we need a new nodes that
>>represent '= TRUE', I'm sure it's required but to a reader of the code
>>it's not obvious why.
>>  
>>
> OK. I will add more comments.

Are you still planning to add these comments at some time?

It seems the committed patch did not include comments in this area.

Even though the patch was reverted I'm sure it will come back with the
correct fix and it would be good to capture your original thoughts when
you created the patch.

Thanks,
Dan.


Mime
View raw message