db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Satheesh Bandaram <sathe...@Sourcery.Org>
Subject Re: [jira] Commented: (DERBY-649) Useful indexes not used in UNION ALL
Date Thu, 15 Dec 2005 15:08:05 GMT
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
  <meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
<body bgcolor="#ffffff" text="#000000">
Thanks for reviewing the patch.<br>
Daniel John Debrunner wrote:<br>
<blockquote cite="mid43A12705.1080407@debrunners.com" type="cite">
  <pre wrap="">Satheesh Bandaram (JIRA) wrote:

  <blockquote type="cite">
    <pre wrap=""> 
I will also enhance this patch to make it more generic for trunk later.
  <pre wrap=""><!---->
When you say  &lt;ColumnReference&gt; &lt;RELOP&gt; &lt;constant&gt;,
can the constant be
a parameter?
Yes, it can.<br>
<blockquote cite="mid43A12705.1080407@debrunners.com" type="cite">
  <pre wrap="">And closely related, in the code (UnionNode.java) you say
'For now, we only push simple
+	 * single column predicates that are binaryOperations.'

Does this need to be clarified? Maybe state explictly what can be pushed
down, maybe 'simple' to you, would be 'complex' to me?
OK. I will expand the comments on this.<br>
<blockquote cite="mid43A12705.1080407@debrunners.com" type="cite">
  <pre wrap="">Could you explain new the code in pushExpressionsIntoSelect? Since you
have spent time on this, it would be great to capture your thoughts in
the code comments. For example, why do we need a new nodes that
represent '= TRUE', I'm sure it's required but to a reader of the code
it's not obvious why.
OK. I will add more comments.<br>
<blockquote cite="mid43A12705.1080407@debrunners.com" type="cite">
  <pre wrap="">
Great patch to improve performance!


View raw message