db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel John Debrunner <...@debrunners.com>
Subject Re: [jira] Commented: (DERBY-739) Reduce generated code required to access a parameter's value
Date Tue, 13 Dec 2005 23:36:24 GMT
Kathey Marsden (JIRA) wrote:

>     [ http://issues.apache.org/jira/browse/DERBY-739?page=comments#action_12360362 ]

> 
> Kathey Marsden commented on DERBY-739:
> --------------------------------------
> 
> Date: Tue Dec 13 13:06:11 2005
> New Revision: 356621
> 
> URL: http://svn.apache.org/viewcvs?rev=356621&view=rev

I belive there is a problem with this patch.

-        mb.callMethod(VMOpcode.INVOKEINTERFACE, (String) null,
"getParameter",
+        mb.callMethod(VMOpcode.INVOKEVIRTUAL, (String) null,
"getParameter",
                       ClassName.DataValueDescriptor, 1);


The new call to "getParameter" says that the declared type of the method
is picked up from the type on the stack, which is 'this', which will
have the type of the generated class. But the getParameter() method is
defined by BaseActivation. Thus the declared type should be passed in.

Dan.



Mime
View raw message