db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel John Debrunner <...@debrunners.com>
Subject Re: [PATCH](DERBY-573) Provide support for optimizer overrides in Derby
Date Fri, 09 Dec 2005 05:29:42 GMT
Mamta Satoor wrote:

> In order to test my upgrade changes, I have used derbyTesting/upgradeTests/phaseTester.java
which was checked in by Dan sometime back. I have changed this test to be a subclass of metadata.java
and then I run the existing metadata tests within phaseTester after various stages of upgrade
on a 10.1 db.


I don't think that phaseTester should be a sub-class of metadata.java.
It's not a metadata test, it's a "harness" for upgrade tests. You don't
need to sub-class another class to use it.
It would be better to keep a clean spearation between phaseTester and
any sub-tests it calls. Can you create an instance of metadata.java and
execute it from phaseTester? This pattern would then work for other
future similar additions, where as you have set up a pattern that can
not be copied due to Java's single inheritance.

Dan.



Mime
View raw message