db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Satheesh Bandaram <sathe...@Sourcery.Org>
Subject Re: [PATCH](DERBY-573) Provide support for optimizer overrides in Derby
Date Tue, 06 Dec 2005 18:55:27 GMT
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
  <meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
  <title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
Great! It will be interesting to see how you are handling soft and hard
upgrades. I will wait for the new patch to start the review.<br>
<br>
Satheesh<br>
<br>
Mamta Satoor wrote:<br>
<blockquote
 cite="midd9619e4a0512061043w7a47136g282ed80dc95fb813@mail.gmail.com"
 type="cite">
  <div>Thanks, Satheesh, for the update. But I am very close to
submitting a new patch for this functionality which will also include
soft and hard upgrade to 10.2 So, give me a day or two to submit the
new patch and then you (and&nbsp;anyone else who might be interested)&nbsp;can
review that patch.
  </div>
  <div>&nbsp;</div>
  <div>thanks,</div>
  <div>Mamta<br>
  <br>
&nbsp;</div>
  <div><span class="gmail_quote">On 12/6/05, <b
 class="gmail_sendername">Satheesh Bandaram</b> &lt;<a
 href="mailto:satheesh@sourcery.org">satheesh@sourcery.org</a>&gt;
wrote:</span>
  <blockquote class="gmail_quote"
 style="border-left: 1px solid rgb(204, 204, 204); margin: 0px 0px 0px 0.8ex; padding-left:
1ex;">Hi
Mamta,<br>
    <br>
I will review with the goal of committing this patch this week. THANKS
for being patient... I was held up trying to get my GrantRevoke Part I
patch out last few weeks.
    <br>
    <span class="sg"><br>
Satheesh</span>
    <div><span class="e" id="q_108014fdc5d71dec_2"><br>
    <br>
Mamta Satoor wrote:
    <blockquote
 cite="http://midd9619e4a0511272224s2c04c4d2qa8b21f99e4a203f3@mail.gmail.com"
 type="cite">
      <div>Hi Everyone,</div>
      <div>&nbsp;</div>
      <div>I posted this patch about 20days back. Does anyone have any
feedback on the patch? Is it good to go?</div>
      <div>&nbsp;</div>
      <div>thanks,</div>
      <div>Mamta<br>
      <br>
&nbsp;</div>
      <div><span class="gmail_quote">On 11/8/05, <b
 class="gmail_sendername">Mamta Satoor</b> &lt;<a
 onclick="return top.js.OpenExtLink(window,event,this)"
 href="mailto:msatoor@gmail.com" target="_blank">msatoor@gmail.com</a>&gt;
wrote:
      </span>
      <blockquote class="gmail_quote"
 style="border-left: 1px solid rgb(204, 204, 204); margin: 0px 0px 0px 0.8ex; padding-left:
1ex;">
        <div>Hi Everyone,</div>
        <div>&nbsp;</div>
        <div>I have the <span name="st">patch</span> for <span
 name="st">optimizer</span> overrides support in Derby. Alongwith the <span
 name="st">patch</span>, I have&nbsp;attached the updated functional spec
to&nbsp;the JIRA entry Derby-573. </div>
        <div>&nbsp;</div>
        <div>Majority of the changes went into the sqlgrammar.jj
because Derby engine already has support for them internally. It is the
parser that needs to recognize these overrides and pass it on to
through the query nodes. The&nbsp;parser now looks for character sequence --
DERBY-PROPERTIES (case insensitive and space between -- and D is
optional) and once it finds that, it looks for propertyName=value pairs
on that same comment line in parser's propertyList method. The parser
does the basic check to make sure that the same property is not used
more than once for a given table. The remaining checks on the
properties like checking the existence of&nbsp;user specified index&nbsp;etc are
done in the bind phase. </div>
        <div>&nbsp;</div>
        <div>I also changed the metadata.properties file to use
--DERBY-PROPERTIES rather than old PROPERTIES clause to supply <span
 name="st">optimizer</span> overrides. In addition, added \n at the end
of the optimier <span name="st">
override</span> comment lines to make sure the comment line does not
get concatenated with the next line of the sql. </div>
        <div>&nbsp;</div>
        <div>Import.java had to be changed to user --DERBY-PROPERTIES
rather than PROPERTIES.</div>
        <div>&nbsp;</div>
        <div>Added a new test optimizerOverrides.sql which runs in both
embedded and network server mode.</div>
        <div>&nbsp;</div>
        <div>Rerunning all the tests after syncing the codeline to make
sure nothing has broken. An earlier run of the tests before the sync
came out clean.</div>
        <div>&nbsp;</div>
        <div>I plan to next work on exposing these overrides through
runtime statistics so that user can verify that the <span name="st">optimizer</span>
overrides&nbsp;are getting used.</div>
        <div>&nbsp;</div>
        <div>I haven't researched into upgrade much but&nbsp;will the
changes in metadata.properties require some upgrade path for existing
databases? Any pointers here will be very useful.</div>
        <div>&nbsp;</div>
        <div>svn stat</div>
        <div>M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; java\engine\org\apache\derby\impl\load\Import.java<br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; java\engine\org\apache\derby\impl\sql\compile\sqlgrammar.jj<br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; java\engine\org\apache\derby\impl\jdbc\metadata.properties<br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; java\engine\org\apache\derby\iapi\reference\SQLState.java
<br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; java\engine\org\apache\derby\loc\messages_en.properties<br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
java\testing\org\apache\derbyTesting\functionTests\tests\lang\db2Compatibility.sql<br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
java\testing\org\apache\derbyTesting\functionTests\tests\lang\copyfiles.ant
        <br>
A&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
java\testing\org\apache\derbyTesting\functionTests\tests\lang\optimizerOverrides.sql<br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
java\testing\org\apache\derbyTesting\functionTests\tests\lang\checkConstraint.sql<br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
java\testing\org\apache\derbyTesting\functionTests\tests\store\access.sql
        </div>
        <div>A&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
java\testing\org\apache\derbyTesting\functionTests\master\DerbyNet\optimizerOverrides.out<br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
java\testing\org\apache\derbyTesting\functionTests\master\db2Compatibility.out<br>
A&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
java\testing\org\apache\derbyTesting\functionTests\master\optimizerOverrides.out
        <br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
java\testing\org\apache\derbyTesting\functionTests\master\checkConstraint.out<br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
java\testing\org\apache\derbyTesting\functionTests\master\access.out<br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
java\testing\org\apache\derbyTesting\functionTests\suites\derbylang.runall
        </div>
        <div>M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
java\testing\org\apache\derbyTesting\functionTests\suites\derbynetmats.runall</div>
        <div>&nbsp;</div>
        <div>Comments/questions on the <span name="st">patch</span>?</div>
        <div>thanks,</div>
        <span>
        <div>Mamta</div>
        </span></blockquote>
      </div>
      <br>
    </blockquote>
    </span></div>
  </blockquote>
  </div>
  <br>
</blockquote>
</body>
</html>


Mime
View raw message