db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernt M. Johnsen" <Bernt.John...@Sun.COM>
Subject Re: [jira] Updated: (DERBY-774) DRDAConnThread::doneData should use statically allocated SQLException objects
Date Wed, 21 Dec 2005 11:30:31 GMT
>>>>>>>>>>>> Bernt M. Johnsen wrote (2005-12-20 21:44:23):
> >>>>>>>>>>>> Dyre Tjeldvoll (JIRA) wrote (2005-12-20
16:48:32):
> >      [ http://issues.apache.org/jira/browse/DERBY-774?page=all ]
> > 
> > Dyre Tjeldvoll updated DERBY-774:
> > ---------------------------------
> > 
> >     Attachment: derby-774.diff
> >                 derby-774.stat
> > 
> > I don't have derbyall_report.txt available, but Knut-Anders promises that he has
run derbyall cleanly with this patch. 
> 
> > As always; a committer's attention would be welcome. Thanks.
> 
> You've got the attenion ;-)

The patch needs a comment that explains why static exceptions are
desirable and why it is ok to use static exceptions in this particluar
case.

Otherwise: ok.
-- 
Bernt Marius Johnsen, Database Technology Group, 
Sun Microsystems, Trondheim, Norway

Mime
View raw message