db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dag H. Wanvik" <Dag.Wan...@Sun.COM>
Subject Re: [PATCH] (Derby-611) Network client: updateRow() causes a commit when autoCommit = true
Date Tue, 13 Dec 2005 19:18:56 GMT

Hi Mamta,

>>>>> "Mamta" == Mamta Satoor <msatoor@gmail.com> wrote:

Mamta> One thing that would be good to have is extend the test that you added to
Mamta> show what happens if we are on the last row in the resultset and
Mamta> updateRow/deleteRow is issued and rollback is sent after that.

Just uploaded a revised patch to include your suggested test
extension; happily it works :)

Dag



Mamta> 
Mamta> thanks,
Mamta> Mamta
Mamta> 
Mamta> 
Mamta> On 12/12/05, Bernt M. Johnsen <Bernt.Johnsen@sun.com> wrote:
Mamta> >
Mamta> > >>>>>>>>>>>> Dag H. Wanvik wrote (2005-12-13
02:18:39):
Mamta> > >
Mamta> > > Hi,
Mamta> > >
Mamta> > > I have a made patch for this, can somebody have a look at it,
Mamta> > > please?
Mamta> >
Mamta> > 1) I think you should add a comment describing the purpose of the
Mamta> > chainAutoCommit variable (why you have to store the
Mamta> > willAutoCommitGenerateFlow) in ResultSet.java
Mamta> >
Mamta> > 2) There is an unnecessary whitespace change in ResultSet.java
Mamta> > >
Mamta> > > From the JIRA:
Mamta> > >
Mamta> > > "I have uploaded a fix for this problem (611.{stat,diff}), and added a
Mamta> > > new test (look for "Positive Test34") to lang/updatableResultSet.java.
Mamta> > > The network client driver canons are also changed in the case of three
Mamta> > > error messages due to the changed behavior, in addition to the change
Mamta> > > due to new test.
Mamta> > >
Mamta> > > The patch removes the explicit (auto)commit code in the network client
Mamta> > > driver in deleteRow and updateRow, making it behave as the embedded
Mamta> > > driver in this respect (modulo error messages).
Mamta> > >
Mamta> > > I have run lang/updatableResultSet.java successfully with Sun jdk 1.3,
Mamta> > > 1.4 and 1.5 (the two latter have another canon) on Solaris
Mamta> > > 10/x86. Also, there is a separate canon under j9_13 for this test,
Mamta> > > which I have updated, but not been able to test.
Mamta> > >
Mamta> > > I have also run derbyall successfully with jdk 1.4, also on Solaris
Mamta> > > 10/x86, albeit with some errors in unrelated tests (lang/dcl,
Mamta> > > store/OnlineBackupTest1.java)"
Mamta> > >
Mamta> > > Thanks,
Mamta> > >
Mamta> > > Dag
Mamta> >
Mamta> > --
Mamta> > Bernt Marius Johnsen, Database Technology Group,
Mamta> > Sun Microsystems, Trondheim, Norway
Mamta> >
Mamta> >
Mamta> >
Mamta> <div>Hi Dag,</div>
Mamta> <div>&nbsp;</div>
Mamta> <div>I am glad we are making Network Server and Embedded behave the same way
in this arena. </div>
Mamta> <div>&nbsp;</div>
Mamta> <div>One thing that would be good to have is extend the test that you added
to show what happens if we are on the last row in the resultset and updateRow/deleteRow is
issued and rollback is sent after that.</div>
Mamta> <div>&nbsp;</div>
Mamta> <div>thanks,</div>
Mamta> <div>Mamta<br><br>&nbsp;</div>
Mamta> <div><span class="gmail_quote">On 12/12/05, <b class="gmail_sendername">Bernt
M. Johnsen</b> &lt;<a href="mailto:Bernt.Johnsen@sun.com">Bernt.Johnsen@sun.com</a>&gt;
wrote:</span>
Mamta> <blockquote class="gmail_quote" style="PADDING-LEFT: 1ex; MARGIN: 0px 0px 0px
0.8ex; BORDER-LEFT: #ccc 1px solid">&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;
Dag H. Wanvik wrote (2005-12-13 02:18:39):<br>&gt;<br>&gt; Hi,
Mamta> <br>&gt;<br>&gt; I have a made patch for this, can somebody
have a look at it,<br>&gt; please?<br><br>1) I think you should add
a comment describing the purpose of the<br>chainAutoCommit variable (why you have to
store the
Mamta> <br>willAutoCommitGenerateFlow) in ResultSet.java<br><br>2) There
is an unnecessary whitespace change in ResultSet.java<br>&gt;<br>&gt;
From the JIRA:<br>&gt;<br>&gt; &quot;I have uploaded a fix for this
problem (611.{stat,diff}), and added a
Mamta> <br>&gt; new test (look for &quot;Positive Test34&quot;) to lang/updatableResultSet.java.<br>&gt;
The network client driver canons are also changed in the case of three<br>&gt; error
messages due to the changed behavior, in addition to the change
Mamta> <br>&gt; due to new test.<br>&gt;<br>&gt; The patch
removes the explicit (auto)commit code in the network client<br>&gt; driver in deleteRow
and updateRow, making it behave as the embedded<br>&gt; driver in this respect (modulo
error messages).
Mamta> <br>&gt;<br>&gt; I have run lang/updatableResultSet.java successfully
with Sun jdk 1.3,<br>&gt; 1.4 and 1.5 (the two latter have another canon) on Solaris<br>&gt;
10/x86. Also, there is a separate canon under j9_13 for this test,
Mamta> <br>&gt; which I have updated, but not been able to test.<br>&gt;<br>&gt;
I have also run derbyall successfully with jdk 1.4, also on Solaris<br>&gt; 10/x86,
albeit with some errors in unrelated tests (lang/dcl,<br>&gt; store/OnlineBackupTest1.java)&quot;
Mamta> <br>&gt;<br>&gt; Thanks,<br>&gt;<br>&gt;
Dag<br><br>--<br>Bernt Marius Johnsen, Database Technology Group,<br>Sun
Microsystems, Trondheim, Norway<br><br><br></blockquote></div><br>
Mamta> 
-- 
Dag H. Wanvik
Sun Microsystems, Database Technology Group (DBTG)
Haakon VII gt. 7b, N-7485 Trondheim, Norway
Tel: x43496/+47 73842196, Fax:  +47 73842101

Mime
View raw message