Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Received-SPF: pass (asf.osuosl.org: local policy)
Date: Wed, 16 Nov 2005 10:42:10 -0800
From: "David W. Van Couvering" <David.Vancouvering@Sun.COM>
Subject: Re: [jira] Updated: (DERBY-289) Enable code sharing between Derby
 client and engine
In-reply-to: <58ed70f50511152039h2ee33319w8ff1facf3c024e90@mail.gmail.com>
To: derby-dev@db.apache.org
Message-id: <437B7D82.1020408@sun.com>
MIME-version: 1.0
Content-type: multipart/mixed; boundary="Boundary_(ID_Kmi09QgG4uiIzlGF/RjIMg)"
User-Agent: Mozilla Thunderbird 1.0.7 (Windows/20050923)
References: <922737490.1131395000353.JavaMail.jira@ajax.apache.org>
 <437099FA.9000001@debrunners.com> <4371307C.5000608@sun.com>
 <4379EF2E.8030103@debrunners.com>
 <58ed70f50511151454j54c264edxafe1afee8df7960d@mail.gmail.com>
 <437A82FF.2040100@sun.com>
 <58ed70f50511152039h2ee33319w8ff1facf3c024e90@mail.gmail.com>

This is a multi-part message in MIME format.

--Boundary_(ID_Kmi09QgG4uiIzlGF/RjIMg)
Content-type: text/plain; charset=ISO-8859-1; format=flowed
Content-transfer-encoding: 7BIT

Great, thanks for your very great analysis, Deepa!  I'll fix these bugs.

David

Deepa Remesh wrote:
> On 11/15/05, David Van Couvering <David.Vancouvering@sun.com> wrote:
> 
> 
>>In the meantime, let's focus on the issue you encountered.  It's funny,
>>the error isn't that the message id was not found.  Instead, we weren't
>>able to find org.apache.derby.loc.client-messages.properties.
> 
> 
> I think this is because the bundle name in ClientMessageUtil has
> ".properties" at the end. ResourceBundle.getBundle expects a class
> name or resource file name without the ".properties".
> 
> private static final String CLIENT_BUNDLE_NAME =  
> "org.apache.derby.loc.client-messages.properties";
> 
> I changed this to "org.apache.derby.loc.client-messages" and it did
> not complain about missing resource file. However it did not find the
> message in any of the resource files and it gave me the following
> message:
> 07000.new : [0] 1
> 
> So the code was actually looking for new message (07000.new). I was
> thinking the code was looking for the old message(07000) and should
> have found it in common-messages_en.properties file. The following
> code which checks if feature is available is not returning the
> expected value when jar versions are mixed:
> 
>             if (!parameterSet_[i] && !parameterRegistered_[i]) {
>                        CommonInfo cInfo = new CommonInfo();
>                        if(cInfo.hasFeature(CommonFeatures.SQLSTATE_07000_NEW))
>                                throw new SqlException2(agent_.logWriter_,
> SQLState.LANG_MISSING_PARMS2, new Integer (i));
>                        else
>                                throw new SqlException2(agent_.logWriter_,
> SQLState.LANG_MISSING_PARMS);
>                }
> 
> 
> In the mixed jar environment (where I have old derby.jar and new
> derbyclient.jar), "hasFeature(CommonFeatures.SQLSTATE_07000_NEW)"
> returns true.
> I looked in derby.jar and it does not have CommonInfo class. So this
> class gets picked from (new) derbyclient.jar, which has this feature
> implemented and hence this method returns true.
> 
> Thanks,
> Deepa

--Boundary_(ID_Kmi09QgG4uiIzlGF/RjIMg)
Content-type: text/x-vcard; charset=utf-8; name=david.vancouvering.vcf
Content-transfer-encoding: 7BIT
Content-disposition: attachment; filename=david.vancouvering.vcf

begin:vcard
fn:David W Van Couvering
n:Van Couvering;David W
org:Sun Microsystems, Inc.;Database Technology Group
email;internet:david.vancouvering@sun.com
title:Senior Staff Software Engineer
tel;work:510-550-6819
tel;cell:510-684-7281
x-mozilla-html:TRUE
version:2.1
end:vcard


--Boundary_(ID_Kmi09QgG4uiIzlGF/RjIMg)--