Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Received-SPF: neutral (asf.osuosl.org: local policy)
Message-ID: <43787FE3.8060203@sbcglobal.net>
Date: Mon, 14 Nov 2005 04:15:31 -0800
From: Kathey Marsden <kmarsdenderby@sbcglobal.net>
User-Agent: Mozilla Thunderbird 0.7.3 (Windows/20040803)
MIME-Version: 1.0
To: derby-dev@db.apache.org
Subject: Re: q re dataSourcePermissions_net and DERBY-410
References: <c25576af0511121448r566512e3i43add4a0f8c4b926@mail.gmail.com>
In-Reply-To: <c25576af0511121448r566512e3i43add4a0f8c4b926@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Myrna van Lunteren wrote:

>Hi,
> I'm working on DERBY-413, trying to remove the hardcoded 'localhost' from
>the tests, and found this comment and subsequent line in the test
>derbynet/dataSourcePermissions_net.java:
>------------------
> if (TestUtil.isJCCFramework())
>{
>attrs.setProperty("driverType","4");
>/**
>* As per the fix of derby-410
>* servername should now default to localhost
>*/
>attrs.setProperty("serverName","localhost");
>}
>-------------------
> Now, if the serverName defaults to localhost, why are we passing it in?
> ?
>  
>
For JCC it has to be set, so it is set   if
(TestUtil.isJCCFramework()).  The comment  might be clearer if it it said

servername should now default to localhost for derbyclient but still needs to be set for JCC.