Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 70963 invoked from network); 2 Nov 2005 21:08:05 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 2 Nov 2005 21:08:05 -0000 Received: (qmail 84149 invoked by uid 500); 2 Nov 2005 21:08:03 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 84114 invoked by uid 500); 2 Nov 2005 21:08:03 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 84103 invoked by uid 99); 2 Nov 2005 21:08:02 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Nov 2005 13:08:02 -0800 X-ASF-Spam-Status: No, hits=2.8 required=10.0 tests=DNS_FROM_RFC_ABUSE,DNS_FROM_RFC_POST,DNS_FROM_RFC_WHOIS X-Spam-Check-By: apache.org Received-SPF: neutral (asf.osuosl.org: local policy) Received: from [32.97.182.143] (HELO e3.ny.us.ibm.com) (32.97.182.143) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Nov 2005 13:07:58 -0800 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e3.ny.us.ibm.com (8.12.11/8.12.11) with ESMTP id jA2L7eOE006777 for ; Wed, 2 Nov 2005 16:07:40 -0500 Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay02.pok.ibm.com (8.12.10/NCO/VERS6.7) with ESMTP id jA2L7eVi121658 for ; Wed, 2 Nov 2005 16:07:40 -0500 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.12.11/8.13.3) with ESMTP id jA2L7eUJ026205 for ; Wed, 2 Nov 2005 16:07:40 -0500 Received: from [127.0.0.1] (dyn9030040113.svl.ibm.com [9.30.40.113] (may be forged)) by d01av03.pok.ibm.com (8.12.11/8.12.11) with ESMTP id jA2L7b35025799 for ; Wed, 2 Nov 2005 16:07:39 -0500 Message-ID: <43692A93.3080207@sbcglobal.net> Date: Wed, 02 Nov 2005 13:07:31 -0800 From: Army User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.1) Gecko/20040707 X-Accept-Language: en-us, en MIME-Version: 1.0 To: derby-dev@db.apache.org Subject: Re: [Derby-573]Optimizer overrides and metadata.properties files References: <43627353.3090906@debrunners.com> <43690859.4040704@debrunners.com> In-Reply-To: <43690859.4040704@debrunners.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Daniel John Debrunner wrote: > I see the same issue, I think it is because the file is being modfied > for ODBC using org.apache.derbyBuild.ODBCMetadataGenerator. There must > be a bug in that process. Yes, in the "readLine" method there is the following logic: char ch; int byteRead; for (byteRead = is.read(); (byteRead != -1) && (count < line.length); byteRead = is.read()) { ch = (char)byteRead; line[count++] = ch; atLeastOneNonWSChar = true; if ((ch == '\\') || (ch == '\n')) break; } The "if" statement assumes a slash indicates the end of the line, but as Mamta pointed out, that's not true. This logic needs to fixed to do the correct thing. I'll look into it if no one else already is... Army