Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Message-ID: <1616143913.1130836796070.JavaMail.jira@ajax.apache.org>
Date: Tue, 1 Nov 2005 10:19:56 +0100 (CET)
From: "Dyre Tjeldvoll (JIRA)" <derby-dev@db.apache.org>
To: derby-dev@db.apache.org
Subject: [jira] Resolved: (DERBY-330) Many files do not have correct
 svn-properties
In-Reply-To: <1834544826.1117543736093.JavaMail.jira@ajax.apache.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

     [ http://issues.apache.org/jira/browse/DERBY-330?page=3Dall ]
    =20
Dyre Tjeldvoll resolved DERBY-330:
----------------------------------

    Resolution: Fixed

Fixed by revision 329187 (committed by =C3=98yvind Bakksj=C3=B8)

> Many files do not have correct svn-properties
> ---------------------------------------------
>
>          Key: DERBY-330
>          URL: http://issues.apache.org/jira/browse/DERBY-330
>      Project: Derby
>         Type: Bug
>   Components: Build tools
>  Environment: Any
>     Reporter: Dyre Tjeldvoll
>     Assignee: Dyre Tjeldvoll
>     Priority: Trivial

>
> There are two problems with svn properties in Derby:
> 1) A number of non-binary files do not have the svn:eol-style=3Dnative pr=
operty set. Some of these currently has CRLF (Windows-style) line terminato=
rs,=20
> Example:
> dt136804@atum10~/local/DERBY/d_rby-138$ file ./plugins/eclipse/org.apache=
.derby.ui/src/org/apache/derby/ui/popup/actions/RemoveDerbyNature.java
> ./plugins/eclipse/org.apache.derby.ui/src/org/apache/derby/ui/popup/actio=
ns/RemoveDerbyNature.java: ASCII C program text, with CRLF line terminators
> dt136804@atum10~/local/DERBY/d_rby-138$ svn proplist -v ./plugins/eclipse=
/org.apache.derby.ui/src/org/apache/derby/ui/popup/actions/RemoveDerbyNatur=
e.java
> whereas others have LF(Unix-style).=20
> Example:
> dt136804@atum10~/local/DERBY/d_rby-138$ file ./plugins/eclipse/org.apache=
.derby.ui/src/org/apache/derby/ui/actions/SysInfoAction.java
> ./plugins/eclipse/org.apache.derby.ui/src/org/apache/derby/ui/actions/Sys=
InfoAction.java: ASCII C program text
> dt136804@atum10~/local/DERBY/d_rby-138$ svn proplist -v ./plugins/eclipse=
/org.apache.derby.ui/src/org/apache/derby/ui/actions/SysInfoAction.java
> Some of the files that don't have this property do instead have a propert=
y called "snv:eol-style". I'm guessing this is a typo.
> Example:
> dt136804@atum10~/local/DERBY/d_rby-138$ svn proplist -v java/testing/org/=
apache/derbyTesting/unitTests/crypto/T_CipherOFB.java
> Properties on 'java/testing/org/apache/derbyTesting/unitTests/crypto/T_Ci=
pherOFB.java':
>   snv:eol-style : native
> 2) A seemingly arbitrary collection of files have the svn:executable prop=
erty set. To my knowledge, the only files in the Derby respository that sho=
uld have this property are the *.ksh and perhaps the *.bat scripts, (I don'=
t know if Windows cares about this property when the file has the .bat suff=
ix). Currently none of the *.ksh scripts have this property, but a number o=
f java source files (not all) have it. (If there is some reason to have thi=
s property on other files, it should at least be done consistently througho=
ut the repository).
> Example:
> dt136804@atum10~/local/DERBY/d_rby-138$ svn proplist -v java/drda/org/apa=
che/derby/drda/NetworkServerControl.java
> Properties on 'java/drda/org/apache/derby/drda/NetworkServerControl.java'=
:
>   svn:executable :
>   svn:eol-style : native
> dt136804@atum10~/local/DERBY/d_rby-138$ svn proplist -v java/testing/org/=
apache/derbyTesting/unitTests/crypto/T_CipherOFB.java
> Properties on 'java/testing/org/apache/derbyTesting/unitTests/crypto/T_Ci=
pherOFB.java':
>   snv:eol-style : native
> If I understand correctly it is not possible to create a patchfile that c=
ontains property changes, so I guess a committer will have to do this. I'm =
willing to create a script file containing all the svn commands that must b=
e run, as a "pseudo patch".

--=20
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira