db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David W. Van Couvering" <David.Vancouver...@Sun.COM>
Subject Re: [jira] Commented: (DERBY-682) Add tests for error codes for severe exceptions
Date Fri, 11 Nov 2005 22:17:43 GMT
OK, great.  It looks like Kathey's going to take care of your patch. 
I'm busy right now fixing Rick's patch to run on UNIX.

David

Deepa Remesh wrote:
> Hi David,
> 
> I had replied to your mail the same day. Not sure what went wrong in
> the mail delivery.  It's in the archives at
> http://www.nabble.com/Re%3A-jira-Updated%3A-%28DERBY-682%29-Add-tests-for-error-codes-for-severe-exceptions-t508285.html#a1377815
> 
> Here is the content of what I wrote:
> ----------------------------------------------------------------------------------------------------------------------------
> Thanks David for looking at the patch.
> 
> For connection pooling, these error codes are used to determine
> whether the connection is valid. The test is just to  flag if those
> error codes change. I found the test lang/errorCode.sql to be a good
> place to add this since it was already testing error messages. I am
> also planning to add tests for client error code -4499 (disconnect
> error). I will upload a patch for this separately.
> 
> Thanks,
> Deepa
> -------------------------------------------------------------------------------------------------------------------------------
> 
> Thanks,
> Deepa
> 
> On 11/11/05, David W. Van Couvering <David.Vancouvering@sun.com> wrote:
> 
>>Hi, Deepa.  After looking at your patch, I sent an email (which I am
>>attaching) that I thought I sent but which I can't find on the archive.
>>  I don't know what happened.
>>
>>My concern is that we are adding a test that basically tests to see that
>>the message text for each message with severity >= session has not
>>changed.  I guess I just don't understand the value in doing that...
>>Can you explain your motivation?
>>
>>Thanks,
>>
>>David
>>
>>Kathey Marsden wrote:
>>
>>>Deepa Remesh (JIRA) wrote:
>>>
>>>
>>>
>>>>If someone can commit it, it would be great.
>>>>
>>>>
>>>>
>>>
>>>Thanks Deepa. I will commit this patch later today.
>>>
>>>Kathey
>>>
>>>
>>
>>
>>
>>---------- Forwarded message ----------
>>From: "David W. Van Couvering" <david.vancouvering@sun.com>
>>To: derby-dev@db.apache.org
>>Date: Mon, 07 Nov 2005 15:52:46 -0800
>>Subject: Re: [jira] Updated: (DERBY-682) Add tests for error codes for severe exceptions
>>Hi, Deepa.  It looks like the original intent of this test is just to
>>make sure that the ErrorMessages VTI looked sane.
>>
>>Why are you adding all these extra select statements to specifically
>>look for every single message with a severity >= session?  Were there
>>certain bugs that you were encountering that motivated you to add these
>>tests?
>>
>>Thanks!
>>
>>David
>>
>>
>>Deepa Remesh (JIRA) wrote:
>>
>>>     [ http://issues.apache.org/jira/browse/DERBY-682?page=all ]
>>>
>>>Deepa Remesh updated DERBY-682:
>>>-------------------------------
>>>
>>>    Attachment: derby-682.diff
>>>                derby-682.status
>>>
>>>Attaching 'derby-682.diff'. This patch adds SQLStates with severity >=session_severity
to the test lang/errorCode.sql. It also updates master files. With this patch, I ran the test
lang/errorCode.sql with Sun JDK 1.4.2 and IBM WSDD5.6 j9_13 VM.
>>>
>>>This patch covers only embedded driver. I will submit another patch for client
driver tests. I will also open another JIRA issue to clean up duplicate entries for SQLStates.
>>>
>>>
>>>
>>>>Add tests for error codes for severe exceptions
>>>>-----------------------------------------------
>>>>
>>>>        Key: DERBY-682
>>>>        URL: http://issues.apache.org/jira/browse/DERBY-682
>>>>    Project: Derby
>>>>       Type: Bug
>>>> Components: Test
>>>>   Versions: 10.2.0.0
>>>>   Reporter: Deepa Remesh
>>>>   Assignee: Deepa Remesh
>>>>   Priority: Minor
>>>>Attachments: derby-682.diff, derby-682.status
>>>>
>>>>Add tests to test error codes for disconnect exceptions and other severe errors
for client and embedded drivers.
>>>
>>>
>>
>>
>>

Mime
View raw message