db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel John Debrunner <...@debrunners.com>
Subject Re: [jira] Updated: (DERBY-675) Build-time processing of "metadata.properties" file handles slashes incorrectly.
Date Thu, 03 Nov 2005 00:19:28 GMT
A B (JIRA) wrote:

>      [ http://issues.apache.org/jira/browse/DERBY-675?page=all ]
> A B updated DERBY-675:
> ----------------------
>     Attachment: d675.patch
> Attaching a patch to fix this issue.  The "readLine" method in ODBCMetadataGenerator.java
was treating single backslashes as "end-of-line" markers and hence was not recognizing escaped
sequences like "\n".  It turns out that the check for backslashes in that method is unnecessary,
so this patch removes it.  I ran the metadata.java and odbc_metadata.java tests with this
patch and they ran okay, so I think it should be safe.  I still want to run some more tests
tonight, just to be sure, but I thought I'd post the patch now since it is affecting another
developer's current work (Mamta's).

Would it be safer to use standard Java character reading classes, rather
than inventing your own here?

Use something like

new LineNumberReader(new InputStreamReader(is, "ISO 8859-1"));

since property files are defined to be that encoding?


View raw message