Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Derby Development" <derby-dev@db.apache.org>
Received-SPF: pass (asf.osuosl.org: domain of m.v.lunteren@gmail.com
 designates 64.233.162.201 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:reply-to:to:subject:mime-version:content-type;
        b=LWvZd/KWnDanrjal4bqFeSFOj+YoB9WhoGHW16aKtSZC0GHyTZpQSXged1hr6FAOmukZxR9UASj+oAIzOmTPSb4zWIw69/rVJzifA6o1zKrm8M3yXS0lNyeISydamk2jE+p59/P1Xe61g8weJrwY/lETMq1+HF7iBAz2BCVcMNE=
Message-ID: <c25576af0510061103t7d9e2076oc17ced975c2347e2@mail.gmail.com>
Date: Thu, 6 Oct 2005 11:03:25 -0700
From: Myrna van Lunteren <m.v.lunteren@gmail.com>
Reply-To: Myrna van Lunteren <m.v.lunteren@gmail.com>
To: derbydev <derby-dev@db.apache.org>
Subject: proposed modification current test harness
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_19643_8166849.1128621805999"

------=_Part_19643_8166849.1128621805999
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Hi,
 As a result of a comment by Dan in reference to DERBY-575,
http://mail-archives.apache.org/mod_mbox/db-derby-dev/200509.mbox/%3c339246=
018.1127141188732.JavaMail.jira@ajax.apache.org%3e

I am proposing the following modification to the current test harness:
 - any read of .properties files and the like will be in original encoding
 effectively, this means to add 'ISO-8859-1' in a number of places where a
InputStreamReader is used in the test harness classes.
- the .out file will be copied into the local encoding and this will be use=
d
in the diff.
 I suggest giving this copied master file extension .tmpmstr - which is wha=
t
happens with networkserver tests.
 Code may need to be added to remove the copied master if the test passes.
 This approach has the following benefit:
 - on a non-ASCII system like zOS the tests can still be run without
requiring all text files to be converted first, but the generated ouptput
and .diff can still be looked at and compared with expected output by a
human
 - the expected output is right there to compare with for a human
investigating a failure, even when you're running with jars. Note that
networkserver already copies the expected output.
 - I am also wondering if this might get around harness bug DERBY-244.
 I'd like to find out if anyone is opposed to this idea.
I know we'd like to get JUnit tests going, but I think this is still a
worthwhile change.
 Thx,
Myrna

------=_Part_19643_8166849.1128621805999
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

<div>Hi,</div>
<div>&nbsp;</div>
<div>As a result of a comment by Dan in reference to DERBY-575, </div>
<div><a onclick=3D"return top.js.OpenExtLink(window,event,this)" href=3D"ht=
tp://mail-archives.apache.org/mod_mbox/db-derby-dev/200509.mbox/%3c33924601=
8.1127141188732.JavaMail.jira@ajax.apache.org%3e" target=3D"_blank">http://=
mail-archives.apache.org/mod_mbox/db-derby-dev/200509.mbox/%3c339246018.112=
7141188732.JavaMail.jira@ajax.apache.org%3e=20
</a></div>
<div>I am proposing the following modification to the current test harness:=
</div>
<div>&nbsp;</div>
<div>- any read of .properties files and the like will be in original encod=
ing</div>
<div>&nbsp;&nbsp;&nbsp; effectively, this means to add 'ISO-8859-1' in a nu=
mber of places where a InputStreamReader is used&nbsp;in the test harness c=
lasses.</div>
<div>- the .out file will be copied into the local encoding and this will b=
e used in the diff.</div>
<div>&nbsp;&nbsp;&nbsp; I suggest&nbsp;giving this copied master file exten=
sion .tmpmstr - which is what happens with networkserver tests.</div>
<div>&nbsp;&nbsp;&nbsp;&nbsp;Code&nbsp;may need&nbsp;to be added to&nbsp;re=
move the copied master&nbsp;if the test passes.</div>
<div>&nbsp;</div>
<div>This approach&nbsp;has the following benefit:</div>
<div>&nbsp;&nbsp;&nbsp; - on a&nbsp;non-ASCII system like zOS the tests can=
 still be run without requiring all text files to be converted first, but t=
he generated ouptput and .diff can still be looked at and compared&nbsp;wit=
h expected output by a human=20
</div>
<div>&nbsp;&nbsp;&nbsp; - the expected output is right there to compare wit=
h for a human investigating a failure, even when you're running with jars. =
Note that networkserver already copies the expected output. </div>
<div>&nbsp;&nbsp;&nbsp; - I am also wondering if this might get around harn=
ess&nbsp;bug DERBY-244.</div>
<div>&nbsp;</div>
<div>I'd like to find out if anyone is opposed to this idea.</div>
<div>I know we'd like to get JUnit tests going, but I think this is still a=
 worthwhile change.</div>
<div>&nbsp;</div>
<div>Thx,</div><span></span><span class=3D"sg">
<div>Myrna</div>
<div>&nbsp;</div></span>

------=_Part_19643_8166849.1128621805999--