Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 75247 invoked from network); 31 Oct 2005 14:35:30 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 31 Oct 2005 14:35:30 -0000 Received: (qmail 56178 invoked by uid 500); 31 Oct 2005 14:35:30 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 55936 invoked by uid 500); 31 Oct 2005 14:35:28 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 55927 invoked by uid 99); 31 Oct 2005 14:35:28 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 31 Oct 2005 06:35:28 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=UNPARSEABLE_RELAY X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [192.18.98.34] (HELO brmea-mail-3.sun.com) (192.18.98.34) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 31 Oct 2005 06:35:24 -0800 Received: from phys-d3-ha21sca-2 ([129.145.155.165]) by brmea-mail-3.sun.com (8.12.10/8.12.9) with ESMTP id j9VEZ73F003372 for ; Mon, 31 Oct 2005 07:35:07 -0700 (MST) Received: from conversion-daemon.ha21sca-mail1.sfbay.sun.com by ha21sca-mail1.sfbay.sun.com (iPlanet Messaging Server 5.2 HotFix 1.24 (built Dec 19 2003)) id <0IP800501B0F1R@ha21sca-mail1.sfbay.sun.com> (original mail from Richard.Hillegas@Sun.COM) for derby-dev@db.apache.org; Mon, 31 Oct 2005 06:35:31 -0800 (PST) Received: from [129.150.26.46] (vpn-129-150-26-46.SFBay.Sun.COM [129.150.26.46]) by ha21sca-mail1.sfbay.sun.com (iPlanet Messaging Server 5.2 HotFix 1.24 (built Dec 19 2003)) with ESMTP id <0IP8005LRB76RK@ha21sca-mail1.sfbay.sun.com> for derby-dev@db.apache.org; Mon, 31 Oct 2005 06:35:31 -0800 (PST) Date: Mon, 31 Oct 2005 06:35:18 -0800 From: Rick Hillegas Subject: Re: [jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby In-reply-to: <2049221901.1130543698172.JavaMail.jira@ajax.apache.org> To: derby-dev@db.apache.org Message-id: <43662BA6.60606@sun.com> MIME-version: 1.0 Content-type: text/plain; charset=UTF-8; format=flowed Content-transfer-encoding: 7BIT X-Accept-Language: en-us, en User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) References: <2049221901.1130543698172.JavaMail.jira@ajax.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Does Derby or Apache have a set of coding guidelines? Where would a new contributor find rules about copyright notices and @author tags? It would be helpful if we had a link to the rules in the 'Contribute Code or Documentation' section of the Community tab. Thanks, -Rick Satheesh Bandaram (JIRA) wrote: > [ http://issues.apache.org/jira/browse/DERBY-587?page=comments#action_12356249 ] > >Satheesh Bandaram commented on DERBY-587: >----------------------------------------- > >I noticed Narayanan doesn't have ICLA signed with Apache. Any "reasonable" size contribution would require the contributor to have an ICLA signed and be on file. List of ICLAs can be found at: http://people.apache.org/~jim/committers.html. The process of starting an ICLA submission: http://www.apache.org/licenses/#clas > >I think it is wise to hold off on checking this in, pending ICLA submission. I was so close... :( > >Several new JAVA files don't have the ASF copyright notices at the top ... Isn't this required for all new JAVA files? > >I also noticed an @author tag in the patch. While I am not sure what guidelines Apache or Derby follows, it may be best to remove @author tags. Geronimo has a policy against this tag: http://wiki.apache.org/geronimo/CodingStandards > >One last minor one... The copyright notice should have 2005 for the file jdk16.java > > > >>Providing JDBC 4.0 support for derby >>------------------------------------ >> >> Key: DERBY-587 >> URL: http://issues.apache.org/jira/browse/DERBY-587 >> Project: Derby >> Type: New Feature >> Components: JDBC >> Versions: 10.2.0.0 >> Reporter: V.Narayanan >> Assignee: V.Narayanan >> Priority: Minor >> Fix For: 10.2.0.0 >> Attachments: jdbc4.0.sxw, jdbc4.diff >> >> >> > > > >