Return-Path: 
 <derby-dev-return-9672-apmail-db-derby-dev-archive=db.apache.org@db.apache.org>
Delivered-To: apmail-db-derby-dev-archive@www.apache.org
Received: (qmail 15776 invoked from network); 25 Oct 2005 23:16:45 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 25 Oct 2005 23:16:45 -0000
Received: (qmail 43524 invoked by uid 500); 25 Oct 2005 23:16:43 -0000
Delivered-To: apmail-db-derby-dev-archive@db.apache.org
Received: (qmail 43491 invoked by uid 500); 25 Oct 2005 23:16:43 -0000
Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:derby-dev-help@db.apache.org>
List-Unsubscribe: <mailto:derby-dev-unsubscribe@db.apache.org>
List-Post: <mailto:derby-dev@db.apache.org>
List-Id: <derby-dev.db.apache.org>
Reply-To: <derby-dev@db.apache.org>
Delivered-To: mailing list derby-dev@db.apache.org
Received: (qmail 43482 invoked by uid 99); 25 Oct 2005 23:16:43 -0000
Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Oct 2005 16:16:43 -0700
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=UNPARSEABLE_RELAY
X-Spam-Check-By: apache.org
Received-SPF: pass (asf.osuosl.org: local policy)
Received: from [192.18.98.34] (HELO brmea-mail-3.sun.com) (192.18.98.34)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Oct 2005 16:16:41 -0700
Received: from phys-d3-ha21sca-2 ([129.145.155.165])
	by brmea-mail-3.sun.com (8.12.10/8.12.9) with ESMTP id j9PNGL3F008884
	for <derby-dev@db.apache.org>; Tue, 25 Oct 2005 17:16:21 -0600 (MDT)
Received: from conversion-daemon.ha21sca-mail1.sfbay.sun.com by
 ha21sca-mail1.sfbay.sun.com
 (iPlanet Messaging Server 5.2 HotFix 1.24 (built Dec 19 2003))
 id <0IOX00C01V8L2X@ha21sca-mail1.sfbay.sun.com>
 (original mail from Richard.Hillegas@Sun.COM) for derby-dev@db.apache.org;
 Tue, 25 Oct 2005 16:16:44 -0700 (PDT)
Received: from [129.150.29.85]
 (vpn-129-150-29-85.SFBay.Sun.COM [129.150.29.85]) by
 ha21sca-mail1.sfbay.sun.com
 (iPlanet Messaging Server 5.2 HotFix 1.24 (built Dec 19 2003))
 with ESMTP id <0IOX00M11VBWC0@ha21sca-mail1.sfbay.sun.com> for
 derby-dev@db.apache.org; Tue, 25 Oct 2005 16:16:44 -0700 (PDT)
Date: Tue, 25 Oct 2005 16:16:32 -0700
From: Rick Hillegas <Richard.Hillegas@Sun.COM>
Subject: Re: DERBY-516 patch review, pt. 1
In-reply-to: <54ac72d70510251459p1e3a57aev5b84ebce69c0b9e8@mail.gmail.com>
To: derby-dev@db.apache.org
Message-id: <435EBCD0.8030601@sun.com>
MIME-version: 1.0
Content-type: text/plain; charset=ISO-8859-1; format=flowed
Content-transfer-encoding: 7BIT
X-Accept-Language: en-us, en
User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716)
References: <9871DBE1-2D24-4FA8-AA74-EAE1ED454FBE@gmail.com>
 <435D4131.3020705@sun.com>
 <54ac72d70510251459p1e3a57aev5b84ebce69c0b9e8@mail.gmail.com>
X-Virus-Checked: Checked by ClamAV on apache.org
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

Hi Andrew,

Thanks for being patient here. Some responses follow. Cheers-Rick


>
>I still currently cannot get the JDBCDriverTest class to compile. The
>problem is that compile.classpath is not guaranteed to be a certain
>level of jdk, and JDBCDriverTest needs to be compiled against JDK 1.3.
>compile.classpath needs to be overridden in certain circumstances, for
>instance when building with J2ME support, with Gump, or on Mac OS X,
>and it is not guaranteed to be the same as java13compile.classpath.
>The problem I'm currently having can be fixed by simply changing
>$[compile.classpath} in the <classpath> element of the <javac> in the
>build.xml of tests/compatibility to ${java13compile.classpath}
>  
>

I will make this change.

>Also, whomever is going to commit the patch needs to be sure that an
>empty master file is created in functionTests/master. My patch program
>skipped over the empty diff without creating an empty patch file.
>  
>

I will have to leave this to David to verify. Unless I'm mis-reading the 
patch output, it seems that my patch does contain an empty master file.

>  
>
>>>7 - The default values in testScript.xml for the locations of the
>>>JVMs are not applicable to Mac OS X (an itchy platform for me). I'll
>>>follow up on this later.
>>>      
>>>
>>If you can tell me what to use here, I'll make the changes.
>>    
>>
>
>I'll get back to you on that. The structure of the JDK directories is
>different on Mac OS X than on Windows, Solaris or Linux, and I believe
>the same is true for some other platforms. It looks like I can work
>around it by directly setting some of the properties set at the
>beginning of the file in my ant.properties.
>  
>

Thanks.

>If you can fix the first problem listed above, and resend the patch,
>then I'm ok with David or someone else committing it. Or, I can commit
>the patch as I have it modified in my local view with the one line
>difference.
>
>andrew
>  
>