Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 43651 invoked from network); 4 Oct 2005 17:43:21 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 4 Oct 2005 17:43:21 -0000 Received: (qmail 918 invoked by uid 500); 4 Oct 2005 17:43:20 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 879 invoked by uid 500); 4 Oct 2005 17:43:19 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: List-Id: Reply-To: "Derby Development" Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 866 invoked by uid 99); 4 Oct 2005 17:43:19 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Oct 2005 10:43:19 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [192.18.42.14] (HELO nwkea-mail-2.sun.com) (192.18.42.14) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Oct 2005 10:43:23 -0700 Received: from phys-mpk-1 ([129.146.11.81]) by nwkea-mail-2.sun.com (8.12.10/8.12.9) with ESMTP id j94HgpHr007360 for ; Tue, 4 Oct 2005 10:42:57 -0700 (PDT) Received: from conversion-daemon.mpk-mail1.sfbay.sun.com by mpk-mail1.sfbay.sun.com (iPlanet Messaging Server 5.2 HotFix 1.24 (built Dec 19 2003)) id <0INU00L01JUHPR@mpk-mail1.sfbay.sun.com> (original mail from David.Vancouvering@Sun.COM) for derby-dev@db.apache.org; Tue, 04 Oct 2005 10:42:54 -0700 (PDT) Received: from [129.150.29.114] (vpn-129-150-29-114.SFBay.Sun.COM [129.150.29.114]) by mpk-mail1.sfbay.sun.com (iPlanet Messaging Server 5.2 HotFix 1.24 (built Dec 19 2003)) with ESMTP id <0INU00ABQJVGF0@mpk-mail1.sfbay.sun.com> for derby-dev@db.apache.org; Tue, 04 Oct 2005 10:42:52 -0700 (PDT) Date: Tue, 04 Oct 2005 10:42:53 -0700 From: "David W. Van Couvering" Subject: Re: [jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby In-reply-to: <4342BB81.5070902@sun.com> To: Derby Development Message-id: <4342BF1D.9000207@sun.com> MIME-version: 1.0 Content-type: multipart/mixed; boundary="Boundary_(ID_NUvZ2uDa6FfbnCA/RXDaDg)" X-Accept-Language: en-us, en User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) References: <1278212735.1128433128269.JavaMail.jira@ajax.apache.org> <4342AA25.4010404@sun.com> <4342BB81.5070902@sun.com> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N This is a multi-part message in MIME format. --Boundary_(ID_NUvZ2uDa6FfbnCA/RXDaDg) Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 8BIT I thought at some point we agreed that at least one independent party should run the tests; this happened after a patch failed to pass tests even though it built -- I think the patch didn't contain a new master file that had been added. It would be nice to add guidelines for checking in a patch to our Wiki site... David �yvind Bakksj� wrote: > David W. Van Couvering wrote: > >> Has somebody other than Narayanan pulled it, built it, and run the tests? >> >> David > > > I always check that stuff builds before committing. As for running the > tests, we usually consider it sufficient if the contributor has run > tests without failure and a reviewer approves the patch, don't we? > --Boundary_(ID_NUvZ2uDa6FfbnCA/RXDaDg) Content-type: text/x-vcard; charset=utf-8; name=david.vancouvering.vcf Content-transfer-encoding: 7BIT Content-disposition: attachment; filename=david.vancouvering.vcf begin:vcard fn:David W Van Couvering n:Van Couvering;David W org:Sun Microsystems, Inc.;Database Technology Group email;internet:david.vancouvering@sun.com title:Senior Staff Software Engineer tel;work:510-550-6819 tel;cell:510-684-7281 x-mozilla-html:TRUE version:2.1 end:vcard --Boundary_(ID_NUvZ2uDa6FfbnCA/RXDaDg)--