Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Derby Development" <derby-dev@db.apache.org>
Received-SPF: pass (asf.osuosl.org: local policy)
Date: Mon, 10 Oct 2005 15:28:28 +0200
From: "Bernt M. Johnsen" <Bernt.Johnsen@Sun.COM>
Subject: Re: [PATCH] [jira] Updated: (DERBY-555) Unable to restart after disk
 is full
In-reply-to: <x1of3bn9h79i.fsf@atum11.norway.sun.com>
To: Derby Development <derby-dev@db.apache.org>
Message-id: <20051010132828.GA17050@atum01.norway.sun.com>
Organization: Sun Microsystems
MIME-version: 1.0
Content-type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary=YZ5djTAD1cGYuMQK
Content-disposition: inline
User-Agent: Mutt/1.5.9i
References: <x1of3bn9h79i.fsf@atum11.norway.sun.com>


--YZ5djTAD1cGYuMQK
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

>>>>>>>>>>>> =D8ystein Gr=F8vlen wrote (2005-10-10 14:43:37):
>=20
> Could someone review/commit the new patch that I added last week?  I
> have run derbyall with no new errors.

Looks ok.
I'll commit if there is one more review.

>=20
> --
> =D8ystein
>=20

> To: derby-dev@db.apache.org
> From: =D8ystein Gr=F8vlen <derby-dev@db.apache.org>
> Subject: [jira] Updated: (DERBY-555) Unable to restart after disk is full
> Date: Tue, 04 Oct 2005 13:06:49 +0200 (CEST)
>=20
>      [ http://issues.apache.org/jira/browse/DERBY-555?page=3Dall ]
>=20
> =C3=98ystein Gr=C3=B8vlen updated DERBY-555:
> ----------------------------------
>=20
>     Attachment: derby-555a.diff
>=20
> Added a new patch that changes the message to derby.log and adds a test f=
or this bug.=20
>=20
> With this patch, when a database is booted in read-only mode, the boot me=
ssage in derby.log will contain information about that.
>=20
> I have also added a test, TurnsReadOnly.java, that without the fix, get t=
he NPE.  This is not in a disk full scenario, but it also occurs with a rea=
d-only DB directory.   Since there is currently no way to turn write access=
 back on from a Java program, the DB directory will be read-only after the =
test is run.  Hence, the test framework will not be able to clean up the te=
st directory.  Therefore, this test is not added to the derbyall test suite.
>=20
> The following files are changed:
>=20
> M      java/engine/org/apache/derby/impl/store/raw/RawStore.java
>       Do not check log location for read-only databases (avoids NPE)
> M      java/engine/org/apache/derby/impl/store/raw/data/BaseDataFileFacto=
ry.java
>       Add information to boot message in derby.log when database is boote=
d in read-only mode.
> M      java/engine/org/apache/derby/iapi/reference/MessageId.java
>       Added message id for the read-only part of the boot message
> M      java/engine/org/apache/derby/loc/messages_en.properties
>       Added text for the read-only part of the boot message
> M      java/testing/org/apache/derbyTesting/functionTests/tests/store/cop=
yfiles.ant
>       Added TurnsReadOnly_app.properties
> A      java/testing/org/apache/derbyTesting/functionTests/tests/store/Tur=
nsReadOnly.java
>       New test that boots a database with log in non-default location, sh=
uts it down, sets DB directory to read-only, boots again and checks that DM=
L is not allowed.
> A      java/testing/org/apache/derbyTesting/functionTests/tests/store/Tur=
nsReadOnly_app.properties
>       Test properties
> A      java/testing/org/apache/derbyTesting/functionTests/master/TurnsRea=
dOnly.out
>       Master file for new test.
>=20
> I am currently running derbyall and will update report when test is finis=
hed.
>=20
> > Unable to restart after disk is full
> > ------------------------------------
> >
> >          Key: DERBY-555
> >          URL: http://issues.apache.org/jira/browse/DERBY-555
> >      Project: Derby
> >         Type: Bug
> >   Components: Store
> >     Versions: 10.2.0.0
> >  Environment: Sun Sparc Solaris, 1.4 JDK, Derby Client/Server
> >     Reporter: =C3=98ystein Gr=C3=B8vlen
> >     Assignee: =C3=98ystein Gr=C3=B8vlen
> >     Priority: Critical
> >  Attachments: derby-555a.diff
> >
> > 1. Inserted data into the database until the disk was full. (5 clients =
inserting into 5 different tables in parallel.)
> > 2. Shut down the server
> > 3. Start the database again without freeing any disk space.
> > When I try to start the database again, I get Null-pointer-exception, r=
egardless of how I connect (have tried embedded, client server, ij, jdbc ap=
plications).  I have not tried to free some space on the disk before starti=
ng. =20
> > The call stack is not available right now (the computer I used had to b=
e shut down due to problems with our cooling system), but the exception com=
es from the following line in RawStore.java:
> >      properties.put(Attribute.LOG_DEVICE, logFactory.getCanonicalLogPat=
h());
> > getCanonicalLogPath() returns null which results in a NPE in the hash t=
able.
> > A quick debug before the computer was stopped, showed that the logFacto=
ry was an instance of org.apache.derby.impl.store.raw.log.ReadOnly which al=
ways returns null in its  getCanonicalLogPath().
> > I suspect this may be related to the fact that I ran with the log in a =
non-default location.
>=20
> --=20
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
>    http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see:
>    http://www.atlassian.com/software/jira
>=20
>=20
>=20

>=20
>=20
> --=20
> =D8ystein


--=20
Bernt Marius Johnsen, Database Technology Group,=20
Sun Microsystems, Trondheim, Norway

--YZ5djTAD1cGYuMQK
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQFDSmx7lFBD9TXBAPARAoZUAJ9DybDKjc57h2pvWU5tI8spKT7XNACfcyJX
BsNRP1ZQ8xk8XkR6Yoim5sk=
=hEAK
-----END PGP SIGNATURE-----

--YZ5djTAD1cGYuMQK--