db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel John Debrunner <...@debrunners.com>
Subject Re: [PATCH] DERBY-597 - Enhance ij connect statement to work in J2ME/CDC/FP
Date Tue, 11 Oct 2005 22:36:09 GMT
Deepa Remesh wrote:

> Hi,
> 
> I have submitted a patch for this and was wondering if someone can
> review it please.
> 
> Thanks,
> Deepa


Setting the database name from the connect as a System property is
probably not the way to go. It's a potential source for confusion as the
value set externally in the _app.properties is overriden. This might be
unexpected to someone trying to debug a test.

System.setProperty("ij.dataSource.databaseName",sVal);

I think the approach you take for the createDatabase property could alos
be used for the databaseName property, pass it into the setupDataSource
method. Though some additional comments on exactly what you are doing
with the create flag would be useful, e.g. how does it interact with the
ij.dataSource.createDatabase property?

Dan.


Mime
View raw message