db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David W. Van Couvering" <David.Vancouver...@Sun.COM>
Subject Re: [jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
Date Tue, 04 Oct 2005 17:42:53 GMT
I thought at some point we agreed that at least one independent party 
should run the tests; this happened after a patch failed to pass tests 
even though it built -- I think the patch didn't contain a new master 
file that had been added.

It would be nice to add guidelines for checking in a patch to our Wiki 
site...

David

Øyvind Bakksjø wrote:
> David W. Van Couvering wrote:
> 
>> Has somebody other than Narayanan pulled it, built it, and run the tests?
>>
>> David
> 
> 
> I always check that stuff builds before committing. As for running the 
> tests, we usually consider it sufficient if the contributor has run 
> tests without failure and a reviewer approves the patch, don't we?
> 

Mime
View raw message