db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kathey Marsden (JIRA)" <derby-...@db.apache.org>
Subject [jira] Commented: (DERBY-597) Enhance ij connect statement to work in J2ME/CDC/FP
Date Tue, 25 Oct 2005 03:27:56 GMT
    [ http://issues.apache.org/jira/browse/DERBY-597?page=comments#action_12355683 ] 

Kathey Marsden commented on DERBY-597:
--------------------------------------

OK, I think I understand the problem and your solution better now.

I   think one method is fine  but I noticed that startJBMS calls this method with a null dbname.
   So it might be clearer if  we got rid of  the firsttime parameter and   then just evaluated
ij.dataSource.databaseName if dbName is null.     Maybe that would make clearer that we are
connecting to the database set in the property  if  one was not specified in the connect..


As for ij.dataSource.createDatabase, why should we ignore it for  subsequent connects?

Anyway I committed the change as it is a marked improvement to connect not working.
You can submit a followon patch for any additional  cleanup or clarification.

Committed revision 328246.

> Enhance ij connect statement to work in J2ME/CDC/FP
> ---------------------------------------------------
>
>          Key: DERBY-597
>          URL: http://issues.apache.org/jira/browse/DERBY-597
>      Project: Derby
>         Type: Improvement
>   Components: Tools
>     Versions: 10.2.0.0, 10.1.1.1
>  Environment: J2ME/CDC/FP
>     Reporter: Deepa Remesh
>     Assignee: Deepa Remesh
>     Priority: Minor
>  Attachments: derby-597-v2.diff, derby-597-v2.status, derby-597.diff, derby-597.status
>
> The connect statement in ij currently uses DriverManager class to get a connection and
so does not work in J2ME environment. Currently in tests, the startJBMS method can optionally
use DataSource to get a connection. This approach can be used in 'connect' statement too.
This change will allow more tests to be run in J2ME.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message