db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Satheesh Bandaram (JIRA)" <derby-...@db.apache.org>
Subject [jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
Date Fri, 28 Oct 2005 23:54:58 GMT
    [ http://issues.apache.org/jira/browse/DERBY-587?page=comments#action_12356249 ] 

Satheesh Bandaram commented on DERBY-587:
-----------------------------------------

I noticed Narayanan doesn't have ICLA signed with Apache.  Any "reasonable" size contribution
would require the contributor to have an ICLA signed and be on file. List of ICLAs can be
found at: http://people.apache.org/~jim/committers.html. The process of starting an ICLA submission:
http://www.apache.org/licenses/#clas

I think it is wise to hold off on checking this in, pending ICLA submission. I was so close...
:(

Several new JAVA files don't have the ASF copyright notices at the top ... Isn't this required
for all new JAVA files?

I also noticed an @author tag in the patch. While I am not sure what guidelines Apache or
Derby follows, it may be best to remove @author tags. Geronimo has a policy against this tag:
http://wiki.apache.org/geronimo/CodingStandards

One last minor one... The copyright notice should have 2005 for the file jdk16.java

> Providing JDBC 4.0 support for derby
> ------------------------------------
>
>          Key: DERBY-587
>          URL: http://issues.apache.org/jira/browse/DERBY-587
>      Project: Derby
>         Type: New Feature
>   Components: JDBC
>     Versions: 10.2.0.0
>     Reporter: V.Narayanan
>     Assignee: V.Narayanan
>     Priority: Minor
>      Fix For: 10.2.0.0
>  Attachments: jdbc4.0.sxw, jdbc4.diff
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message