db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Deepa Remesh (JIRA)" <derby-...@db.apache.org>
Subject [jira] Updated: (DERBY-498) Result set holdability defined inside stored procedures is ignored by server/client
Date Thu, 06 Oct 2005 16:20:48 GMT
     [ http://issues.apache.org/jira/browse/DERBY-498?page=all ]

Deepa Remesh updated DERBY-498:

    Attachment: derby-498.diff

The attached patch 'derby-498.diff' changes network server to use statement holdability set
within stored procedures. The patch does the following:

1. For callable statements, the execute method in DRDAStatement gets holdability from the
statement that produced the resultset. 
2. Added getResultSetHoldability method which takes a resultset and returns holdability.
3. execute method passes this holdability to addResultSet method, which sets DRDAResultSet.withHoldCursor
with this value.
4. writeOPNQRYRM method in DRDAConnThread is changed to use the holdability of the current
DRDAResultSet for setting SQLCSRHLD.
5. Added tests in lang/holdCursorJava.java. Created a new master file for DerbyNetClient.

Ran derbyall on WinXP Sun jdk1.4.2. No failures. However, in a previous run of derbyall I
got failures in few encryption tests. The failures did not seem related to my change. So I
ran the encryption suites again and they passed. Then ran derbyall again and all tests passed.

While working on this patch, I found some changes were affecting XA tests. I think the patch
I uploaded does not have any side effects. But I am new to this and would greatly appreciate
if someone can review and give me feedback. Once this is reviewed/committed, I would like
to merge this to 10.1 branch too.

> Result set holdability defined inside stored procedures is ignored by server/client
> -----------------------------------------------------------------------------------
>          Key: DERBY-498
>          URL: http://issues.apache.org/jira/browse/DERBY-498
>      Project: Derby
>         Type: Bug
>   Components: Network Client, Network Server
>     Versions:,
>     Reporter: A B
>     Assignee: Deepa Remesh
>  Attachments: d498.java, derby-498.diff, derby-498.status
> Assume I have a Java stored procedure that returns one or more result sets, and the holdability
of those result sets is specified as part of the createStatement() method within the procedure
definition (see below for an example).
> If I execute this procedure against Derby embedded, the holdability of each result set
matches that of the statement-specific holdability that is defined within the stored procedure.
 However, if I run the procedure against the Network Server using the Derby client, the holdability
of _all_ result sets is the same, and it is based on the holdability of the statement that
_executed_ the procedure--i.e. the statement-specific holdability that is defined within the
procedure is ignored.
> Ex: If I create a stored procedure that corresponds to the following method:
> public static void p2(ResultSet[] rs1, ResultSet[] rs2,
>     ResultSet[] rs3) throws Exception
> {
>     Connection conn = DriverManager.getConnection(
>         "jdbc:default:connection");
>     Statement st1 = conn.createStatement(
>         ResultSet.TYPE_FORWARD_ONLY,
>         ResultSet.CONCUR_READ_ONLY,
>         ResultSet.HOLD_CURSORS_OVER_COMMIT);
>     rs1[0] = st1.executeQuery("select * from testtable1");
>     Statement st2 = conn.createStatement(
>         ResultSet.TYPE_FORWARD_ONLY,
>         ResultSet.CONCUR_READ_ONLY,
>         ResultSet.CLOSE_CURSORS_AT_COMMIT);
>     rs2[0] = st2.executeQuery("select * from testtable2");
>     Statement st3 = conn.createStatement(
>         ResultSet.TYPE_FORWARD_ONLY,
>         ResultSet.CONCUR_READ_ONLY,
>         ResultSet.HOLD_CURSORS_OVER_COMMIT);
>     rs3[0] = st3.executeQuery("select * from testtable3");
>     return;
>     }
> }
> Then with Derby embedded, if I have a JDBC Statement that executes a call to this procedure,
rs1 and rs3 will behave with HOLD_CURSORS holdability and rs2 will behave with CLOSE_CURSORS
holdability--and that will be the case regardless of the holdability on the Statement that
executed the call.  That seems correct to me.
> But if I do the same thing with Network Server, all of the result sets (rs1, rs2, and
rs3) will have the same holdability as the JDBC Statement that executed the call.  It doesn't
matter what the holdabilities used within the procedure definition are: they will all be over-ridden
by the holdability of the Statement that made the call.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
For more information on JIRA, see:

View raw message