db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Craig Russell (JIRA)" <derby-...@db.apache.org>
Subject [jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
Date Tue, 01 Nov 2005 05:38:56 GMT
    [ http://issues.apache.org/jira/browse/DERBY-587?page=comments#action_12356473 ] 

Craig Russell commented on DERBY-587:
-------------------------------------

I have just a few comments.

1. The code does not appear to be consistent with regard to spaces, tabs, indents, and which
line the "{" appears on. Are there coding standards to which we try to hold contributions?
Other projects recognize that some files in the same project use different coding styles (standards?)
but try to maintain standards for new files. The rule is that patches to existing files use
the conventions already used, but new files have a standard approach. Are there any such standards
for Derby?

2. The copyright notices definitely need to be there for this contribution.

3. I agree that for a contribution of this magnitude, a signed ICLA should be a requirement.

4. In response to Dan's comments immediately above, I'd think that the Apache board might
want to discuss why the JIRA has a check box for contributions. If it's really irrelevant,
it's certainly a distraction.




> Providing JDBC 4.0 support for derby
> ------------------------------------
>
>          Key: DERBY-587
>          URL: http://issues.apache.org/jira/browse/DERBY-587
>      Project: Derby
>         Type: New Feature
>   Components: JDBC
>     Versions: 10.2.0.0
>     Reporter: V.Narayanan
>     Assignee: V.Narayanan
>     Priority: Minor
>      Fix For: 10.2.0.0
>  Attachments: jdbc4.0.sxw, jdbc4.diff
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message