Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 55290 invoked from network); 1 Sep 2005 12:40:08 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 1 Sep 2005 12:40:08 -0000 Received: (qmail 39717 invoked by uid 500); 1 Sep 2005 12:40:08 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 39496 invoked by uid 500); 1 Sep 2005 12:40:07 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: List-Id: Reply-To: "Derby Development" Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 39483 invoked by uid 99); 1 Sep 2005 12:40:07 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=SPF_FAIL X-Spam-Check-By: apache.org Received: from [192.87.106.226] (HELO ajax.apache.org) (192.87.106.226) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Sep 2005 05:40:06 -0700 Received: from ajax.apache.org (ajax.apache.org [127.0.0.1]) by ajax.apache.org (Postfix) with ESMTP id B0B36E0 for ; Thu, 1 Sep 2005 14:40:05 +0200 (CEST) Message-ID: <1204798528.1125578405721.JavaMail.jira@ajax.apache.org> Date: Thu, 1 Sep 2005 14:40:05 +0200 (CEST) From: "Dyre Tjeldvoll (JIRA)" To: derby-dev@db.apache.org Subject: [jira] Assigned: (DERBY-330) Many files do not have correct svn-properties In-Reply-To: <1834544826.1117543736093.JavaMail.jira@ajax.apache.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N [ http://issues.apache.org/jira/browse/DERBY-330?page=all ] Dyre Tjeldvoll reassigned DERBY-330: ------------------------------------ Assign To: Dyre Tjeldvoll > Many files do not have correct svn-properties > --------------------------------------------- > > Key: DERBY-330 > URL: http://issues.apache.org/jira/browse/DERBY-330 > Project: Derby > Type: Bug > Components: Build tools > Environment: Any > Reporter: Dyre Tjeldvoll > Assignee: Dyre Tjeldvoll > Priority: Trivial > > There are two problems with svn properties in Derby: > 1) A number of non-binary files do not have the svn:eol-style=native property set. Some of these currently has CRLF (Windows-style) line terminators, > Example: > dt136804@atum10~/local/DERBY/d_rby-138$ file ./plugins/eclipse/org.apache.derby.ui/src/org/apache/derby/ui/popup/actions/RemoveDerbyNature.java > ./plugins/eclipse/org.apache.derby.ui/src/org/apache/derby/ui/popup/actions/RemoveDerbyNature.java: ASCII C program text, with CRLF line terminators > dt136804@atum10~/local/DERBY/d_rby-138$ svn proplist -v ./plugins/eclipse/org.apache.derby.ui/src/org/apache/derby/ui/popup/actions/RemoveDerbyNature.java > whereas others have LF(Unix-style). > Example: > dt136804@atum10~/local/DERBY/d_rby-138$ file ./plugins/eclipse/org.apache.derby.ui/src/org/apache/derby/ui/actions/SysInfoAction.java > ./plugins/eclipse/org.apache.derby.ui/src/org/apache/derby/ui/actions/SysInfoAction.java: ASCII C program text > dt136804@atum10~/local/DERBY/d_rby-138$ svn proplist -v ./plugins/eclipse/org.apache.derby.ui/src/org/apache/derby/ui/actions/SysInfoAction.java > Some of the files that don't have this property do instead have a property called "snv:eol-style". I'm guessing this is a typo. > Example: > dt136804@atum10~/local/DERBY/d_rby-138$ svn proplist -v java/testing/org/apache/derbyTesting/unitTests/crypto/T_CipherOFB.java > Properties on 'java/testing/org/apache/derbyTesting/unitTests/crypto/T_CipherOFB.java': > snv:eol-style : native > 2) A seemingly arbitrary collection of files have the svn:executable property set. To my knowledge, the only files in the Derby respository that should have this property are the *.ksh and perhaps the *.bat scripts, (I don't know if Windows cares about this property when the file has the .bat suffix). Currently none of the *.ksh scripts have this property, but a number of java source files (not all) have it. (If there is some reason to have this property on other files, it should at least be done consistently throughout the repository). > Example: > dt136804@atum10~/local/DERBY/d_rby-138$ svn proplist -v java/drda/org/apache/derby/drda/NetworkServerControl.java > Properties on 'java/drda/org/apache/derby/drda/NetworkServerControl.java': > svn:executable : > svn:eol-style : native > dt136804@atum10~/local/DERBY/d_rby-138$ svn proplist -v java/testing/org/apache/derbyTesting/unitTests/crypto/T_CipherOFB.java > Properties on 'java/testing/org/apache/derbyTesting/unitTests/crypto/T_CipherOFB.java': > snv:eol-style : native > If I understand correctly it is not possible to create a patchfile that contains property changes, so I guess a committer will have to do this. I'm willing to create a script file containing all the svn commands that must be run, as a "pseudo patch". -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira