db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel John Debrunner <...@debrunners.com>
Subject Re: [jira] Commented: (DERBY-525) getAsciiStreamshould replace non-ASCII characters with 0x3f, '?' to match embedded
Date Thu, 29 Sep 2005 17:52:35 GMT
Sunitha Kambhampati (JIRA) wrote:

>     [ http://issues.apache.org/jira/browse/DERBY-525?page=comments#action_12330828 ]

> 
> Sunitha Kambhampati commented on DERBY-525:
> -------------------------------------------
> 
> It would be great if you could add a testcase for this.
> 
> I looked at the patch briefly, and had one minor comment.  In convertToAsciiByteArray,
it might be better performance wise, if we calculate the original.length only once and use
it in the for loop.


Also I would strongly encourage you to add comments to code you add to
Derby. In the future someone may be confused by what exactly the
function is doing and what this line is:

result[i] = 0x003f;

A one or two line javadoc comment in the method description would suffice.

Thanks,
Dan.



Mime
View raw message