db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "TomohitoNakayama" <tomon...@basil.ocn.ne.jp>
Subject Re: [jira] Commented: (DERBY-525) getAsciiStreamshould replace non-ASCII characters with 0x3f, '?' to match embedded
Date Thu, 29 Sep 2005 22:22:17 GMT
Hello.

I see. I will work for them .

Best regards.

/*

         Tomohito Nakayama
         tomonaka@basil.ocn.ne.jp
         tomohito@rose.zero.ad.jp
         tmnk@apache.org

         Naka
         http://www5.ocn.ne.jp/~tomohito/TopPage.html

*/
----- Original Message ----- 
From: "Daniel John Debrunner" <djd@debrunners.com>
To: "Derby Development" <derby-dev@db.apache.org>
Sent: Friday, September 30, 2005 2:52 AM
Subject: Re: [jira] Commented: (DERBY-525) getAsciiStreamshould replace non-ASCII characters
with 0x3f, '?' to match embedded


> Sunitha Kambhampati (JIRA) wrote:
>
>>     [ http://issues.apache.org/jira/browse/DERBY-525?page=comments#action_12330828
]
>>
>> Sunitha Kambhampati commented on DERBY-525:
>> -------------------------------------------
>>
>> It would be great if you could add a testcase for this.
>>
>> I looked at the patch briefly, and had one minor comment.  In convertToAsciiByteArray,
it might be better performance wise, if we 
>> calculate the original.length only once and use it in the for loop.
>
>
> Also I would strongly encourage you to add comments to code you add to
> Derby. In the future someone may be confused by what exactly the
> function is doing and what this line is:
>
> result[i] = 0x003f;
>
> A one or two line javadoc comment in the method description would suffice.
>
> Thanks,
> Dan.
>
>
>
>
>
> -- 
> No virus found in this incoming message.
> Checked by AVG Anti-Virus.
> Version: 7.0.344 / Virus Database: 267.11.8/114 - Release Date: 2005/09/28
>
> 



-- 
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.344 / Virus Database: 267.11.8/114 - Release Date: 2005/09/28


Mime
View raw message