Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Derby Development" <derby-dev@db.apache.org>
Received-SPF: neutral (asf.osuosl.org: local policy)
Message-ID: <42DFC8BA.70007@sbcglobal.net>
Date: Thu, 21 Jul 2005 09:09:30 -0700
From: Mike Matrigali <mikem_app@sbcglobal.net>
User-Agent: Mozilla Thunderbird 0.7.2 (Windows/20040707)
MIME-Version: 1.0
To: Derby Development <derby-dev@db.apache.org>
Subject: Re: [PATCH]derby-105 :drop table statement shows wrong message after
 dropping table
References: <42DF777C.6040503@debrunners.com>
 <42DF7881.8000108@debrunners.com>
In-Reply-To: <42DF7881.8000108@debrunners.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Just my opinion, but it seems like madness to have IJ start
parsing the SQL text it sends, just to have it say insert
vs. delete.  It seems like a lot of code complication for
not much benefit.

At least currently I believe ij can also be used to connect
to other db's so it may not even know the syntax that it
could accept.

By all means if jdbc returns something that can be used to
qualify the tag line, that seems reasonable.

Daniel John Debrunner wrote:

> Daniel John Debrunner wrote:
> 
> 
>>V.Narayanan@Sun.COM wrote
>>
>>
>>
>>
>>>     INSERT INTO WORKS1
>>>            SELECT *
>>>                 FROM WORKS;
>>>-12 rows inserted/updated/deleted
>>>+12 --s executed
>>
>>
>>The patch seems to have problems, several of the correct execution
>>status lines in the test output have been replaced with lines that make
>>no sense. Ie. in this case '--s executed'.
>>
>>This is the danger of getting ij parsing SQL text, it may not have the
>>same understanding as the underlying SQL engine, which may not be Derby.
> 
> 
> I meant to add I think it may be possible to tell from the JDBC api if a
> statement execution returns:
> 
>   - ResultSet
>   - update count
>   - other execution (e.g. DDL)
> 
> For the first two, ij does do the correct behaviour now. For the latter,
> ij prints out the 0 rows inserted/upodated/deleted, but maybe it should
> print out a simple 'statement executed'. Though I could never figure out
> exactly how to tell from JDBC which type of statement it is.
> 
> Dan.
> 
>