db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel John Debrunner <...@debrunners.com>
Subject Re: [PATCH]derby-105 :drop table statement shows wrong message after dropping table
Date Thu, 21 Jul 2005 10:27:13 GMT
Daniel John Debrunner wrote:

> V.Narayanan@Sun.COM wrote
> 
> 
> 
>>      INSERT INTO WORKS1
>>             SELECT *
>>                  FROM WORKS;
>>-12 rows inserted/updated/deleted
>>+12 --s executed
> 
> 
> The patch seems to have problems, several of the correct execution
> status lines in the test output have been replaced with lines that make
> no sense. Ie. in this case '--s executed'.
> 
> This is the danger of getting ij parsing SQL text, it may not have the
> same understanding as the underlying SQL engine, which may not be Derby.

I meant to add I think it may be possible to tell from the JDBC api if a
statement execution returns:

  - ResultSet
  - update count
  - other execution (e.g. DDL)

For the first two, ij does do the correct behaviour now. For the latter,
ij prints out the 0 rows inserted/upodated/deleted, but maybe it should
print out a simple 'statement executed'. Though I could never figure out
exactly how to tell from JDBC which type of statement it is.

Dan.


Mime
View raw message