db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel John Debrunner <...@debrunners.com>
Subject Re: [jira] Updated: (DERBY-406) Client DataSource should not require user property to be set
Date Fri, 01 Jul 2005 19:10:35 GMT
Philip Wilder (JIRA) wrote:

>      [ http://issues.apache.org/jira/browse/DERBY-406?page=all ]
> 
> Philip Wilder updated DERBY-406:
> --------------------------------
> 
>     Attachment: Derby406_409_410.patch
> 
> A Combined patch for DERBY-406, DERBY-409 and DERBY-410

So how is this patch different to the one described early?

I would disagree with having a default value for password.

[Philip's earlier description]
> - Set password to a default value ("defaultpassword")
> - Set user to default to "APP"
> - Set the default servername to "localhost"
> - Changed the updateDataSourceValues of the ClientBaseDataSource class to update the
password value if a password is found in the connection attributes.
> - Changed
> databaseName_ = dataSource.getDatabaseName() + attrString;
> to
> databaseName_ = dataSource.getDatabaseName() + ";" + attrString;
> in the connection class to avoid database names like myDBcreate=true when the setConnectionAttributes
method is used.
> - Changed the dataSourcePermissions_net to include additional tests to check bug fixes
and changed the associated.out file to match new output.
> 
> Also with regards to the "Client data source published api javadoc cleanup" email sent
out by Dan I changed the password, user and servername attributes to private so as to hopefully
not conflict with his changes. 

Actually, performing such a change yourself is more likely to cause
conflict. Just focus on your own changes don't try to pre-incorporate
other changes. :-)

Dan.



Mime
View raw message