db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kathey Marsden (JIRA)" <derby-...@db.apache.org>
Subject [jira] Created: (DERBY-433) Minor code cleanup is needed in NetXAResource
Date Fri, 01 Jul 2005 18:04:58 GMT
Minor code cleanup is needed in NetXAResource 
----------------------------------------------

         Key: DERBY-433
         URL: http://issues.apache.org/jira/browse/DERBY-433
     Project: Derby
        Type: Sub-task
  Components: Network Client  
    Versions: 10.1.1.0, 10.2.0.0    
    Reporter: Kathey Marsden


These are a few items  items that should be cleaned up in NetXAResource and related files.
 There are surely other items as well.

1)  In setXaStateForXAException(int rc), rc codes that do not change the xa state should be
verified and checked individually and an assertion thrown for unexpected return codes.

2)  Remove infrastructure for chaining xa calls.  The client xa implementation used to queue
up xa requests and had an assocated callInfoArray, e.g.
	// TODO: change to a single callInfo field (not an array)
    NetXACallInfo callInfoArray_[] =
            new NetXACallInfo[INITIAL_CALLINFO_ELEMENTS];

3)Remove residual code related to making secondary connections for recover.  
   
For example in NetXAResource ..
String rmIdx_; // userid in case we need to create a secondary connection
    String rmIdy_; // password in case we need to create a secondary connection
    // TODO: remove port and ipaddr_
    int port_;     // port needed to make secondary connection for recover in DS mode.
    String ipaddr_;  // ip address needed to make secondary connection for recover in DS mode.

4) eliminate unused fields in NetXAResource, such as activeXATransCount_



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message