Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 21517 invoked from network); 8 Jun 2005 13:01:14 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 8 Jun 2005 13:01:14 -0000 Received: (qmail 96165 invoked by uid 500); 8 Jun 2005 13:01:13 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 96121 invoked by uid 500); 8 Jun 2005 13:01:13 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: List-Id: Reply-To: "Derby Development" Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 96108 invoked by uid 99); 8 Jun 2005 13:01:13 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: local policy) Received: from brmea-mail-4.Sun.COM (HELO brmea-mail-4.sun.com) (192.18.98.36) by apache.org (qpsmtpd/0.28) with ESMTP; Wed, 08 Jun 2005 06:01:09 -0700 Received: from phys-epost-2 ([129.159.136.31]) by brmea-mail-4.sun.com (8.12.10/8.12.9) with ESMTP id j58D0vau023080 for ; Wed, 8 Jun 2005 07:00:57 -0600 (MDT) Received: from conversion-daemon.epost-mail1.sweden.sun.com by epost-mail1.sweden.sun.com (iPlanet Messaging Server 5.2 HotFix 1.24 (built Dec 19 2003)) id <0IHR00501O44OJ@epost-mail1.sweden.sun.com> (original mail from Oystein.Grovlen@Sun.COM) for derby-dev@db.apache.org; Wed, 08 Jun 2005 15:00:56 +0200 (MEST) Received: from atum11.Norway.Sun.COM.sun.com (atum11.Norway.Sun.COM [129.159.112.211]) by epost-mail1.sweden.sun.com (iPlanet Messaging Server 5.2 HotFix 1.24 (built Dec 19 2003)) with ESMTP id <0IHR009SCO5JPT@epost-mail1.sweden.sun.com> for derby-dev@db.apache.org; Wed, 08 Jun 2005 15:00:56 +0200 (MEST) Date: Wed, 08 Jun 2005 15:00:55 +0200 From: Oystein.Grovlen@Sun.COM (=?iso-8859-1?q?=D8ystein_Gr=F8vlen?=) Subject: Re: [jira] Updated: (DERBY-243) connection toString should uniquely identify the connection In-reply-to: <1935720657.1118205047046.JavaMail.jira@ajax.apache.org> To: Derby Development Message-id: MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-transfer-encoding: 8BIT User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/21.2 Lines: 36 References: <1935720657.1118205047046.JavaMail.jira@ajax.apache.org> X-Virus-Checked: Checked X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N >>>>> "DVC(" == David Van Couvering (JIRA) writes: DVC(> [ http://issues.apache.org/jira/browse/DERBY-243?page=all ] DVC(> David Van Couvering updated DERBY-243: DVC(> -------------------------------------- DVC(> Attachment: DERBY-243.diff DVC(> Updated patch for this issue. Here is a summary of what I changed. A lot of what I did was remove code I had put in, DVC(> so I think you'll see a much simpler patch. Looks very good. I am running derbylang on it know and will let you know about the results when it is finished. A few minor comments: - EmbedPooledConnection.toString(): You do not have to create an Integer object to convert int to String. You can use the static Integer.toString(int) function. - There is some unecessary white space changes. Adding or removing empty lines are OK, but the use of "svn blame" (or praise) becomes less useful if lines that are unrelated to the check-in are changed. Even worse, checkDataSource30.java only contains white space changes. This gives the false impression that this test is changed by your fix. - The Javadoc for checkDataSource.checkToString(Connection) seems to lack the word "sure". - You have changed the checkDataSource.main test so it may throw an Exception. What is the purpose of that. Will the test harness handle the Exception? -- �ystein