Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 34615 invoked from network); 4 Jun 2005 15:48:55 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 4 Jun 2005 15:48:55 -0000 Received: (qmail 58114 invoked by uid 500); 4 Jun 2005 15:48:54 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 58081 invoked by uid 500); 4 Jun 2005 15:48:53 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: List-Id: Reply-To: "Derby Development" Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 58067 invoked by uid 99); 4 Jun 2005 15:48:53 -0000 X-ASF-Spam-Status: No, hits=0.1 required=10.0 tests=HTML_40_50,HTML_MESSAGE,RCVD_BY_IP,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: domain of msatoor@gmail.com designates 64.233.184.201 as permitted sender) Received: from wproxy.gmail.com (HELO wproxy.gmail.com) (64.233.184.201) by apache.org (qpsmtpd/0.28) with ESMTP; Sat, 04 Jun 2005 08:48:51 -0700 Received: by wproxy.gmail.com with SMTP id 58so2029270wri for ; Sat, 04 Jun 2005 08:48:49 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:in-reply-to:mime-version:content-type:references; b=gzVSJp7vGealPSGOnNZQsyEigFPdP9xxS8gb84vUGa5sWJG+/2Big02kiG7lCgLYd5kZaPDjvQ1N446YPkXxFZS/P7Bl/sY9DRmgzSoEXj9Q4Seok9HglJZ6V/1EoGtrkCmRuV0lZzSORh9U4ECAak++M4+uTDJov5ekftDrDrs= Received: by 10.54.2.42 with SMTP id 42mr2114281wrb; Sat, 04 Jun 2005 08:47:59 -0700 (PDT) Received: by 10.54.49.54 with HTTP; Sat, 4 Jun 2005 08:47:59 -0700 (PDT) Message-ID: Date: Sat, 4 Jun 2005 08:47:59 -0700 From: Mamta Satoor Reply-To: Mamta Satoor To: Derby Development Subject: Re: [PATCH] Updatable Resultset JDBC api (update and delete for forward only updatable resultsets) support for Network Server In-Reply-To: <429248A1.8050005@Sourcery.Org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_5479_16286303.1117900079389" References: <428CB8F3.1010605@vancouvering.com> <429248A1.8050005@Sourcery.Org> X-Virus-Checked: Checked X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N ------=_Part_5479_16286303.1117900079389 Content-Type: multipart/alternative; boundary="----=_Part_5480_20404904.1117900079389" ------=_Part_5480_20404904.1117900079389 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Hi Satheesh, I have a very small patch to address your review comments on Updatable=20 Resultset support for Network Server using Derby Net Client. svn stat=20 M java\client\org\apache\derby\client\am\ResultSet.java Please commit it if there are no issues. thanks, Mamta On 5/23/05, Satheesh Bandaram wrote:=20 >=20 > Some minor comments... Use them if they apply.... >=20 >=20 > 1. Not sure if resultSetMetaData_.sqlxRdbnam_[baseTableColumn] is=20 > ever set, so no need to check for that.=20 > 2. Use sqlxBasename_ instead of sqlxSchema_ when looking for a valid= =20 > base table. While both may work, it may be more readable.=20 >=20 > Satheesh >=20 > ------=_Part_5480_20404904.1117900079389 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline
Hi Satheesh,
 
I have a very small patch to address your review comments on= Updatable Resultset support for Network Server using Derby Net Client.
 
svn stat
M      java\client\org\apache\derby\client\am= \ResultSet.java
 
Please commit it if there are no issues.
 
thanks,
Mamta

 
On 5/23/05, = Satheesh Bandaram <satheesh= @sourcery.org> wrote:
Some minor comments... Use them = if they apply....

  1. Not sure if resultSetMetaData_.sqlxRdbnam_[baseTableColumn] is ever set= , so no need to check for that.=20
  2. Use sqlxBasename_ instead of sqlxSchema_ when looking for a valid base = table. While both may work, it may be more readable.
Sathees= h

 
------=_Part_5480_20404904.1117900079389-- ------=_Part_5479_16286303.1117900079389 Content-Type: text/plain; name="UpdatableResultsetNScleanup.txt" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="UpdatableResultsetNScleanup.txt" SW5kZXg6IGphdmEvY2xpZW50L29yZy9hcGFjaGUvZGVyYnkvY2xpZW50L2FtL1Jlc3VsdFNldC5q YXZhDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09DQotLS0gamF2YS9jbGllbnQvb3JnL2FwYWNoZS9kZXJieS9jbGllbnQv YW0vUmVzdWx0U2V0LmphdmEJKHJldmlzaW9uIDE3OTc5MykNCisrKyBqYXZhL2NsaWVudC9vcmcv YXBhY2hlL2RlcmJ5L2NsaWVudC9hbS9SZXN1bHRTZXQuamF2YQkod29ya2luZyBjb3B5KQ0KQEAg LTMxMzQsNyArMzEzNCw3IEBADQogICAgICAgICBpbnQgYmFzZVRhYmxlQ29sdW1uID0gMDsKICAg ICAgICAgaW50IHRvdGFsQ29sdW1ucyA9IHJlc3VsdFNldE1ldGFEYXRhXy5nZXRDb2x1bW5Db3Vu dCgpOwogICAgICAgICBmb3IgKDsgYmFzZVRhYmxlQ29sdW1uIDwgdG90YWxDb2x1bW5zOyBiYXNl VGFibGVDb2x1bW4rKykgewotICAgICAgICAgICAgaWYgKHJlc3VsdFNldE1ldGFEYXRhXy5zcWx4 U2NoZW1hX1tiYXNlVGFibGVDb2x1bW5dICE9IG51bGwpCisgICAgICAgICAgICBpZiAocmVzdWx0 U2V0TWV0YURhdGFfLnNxbHhCYXNlbmFtZV9bYmFzZVRhYmxlQ29sdW1uXSAhPSBudWxsKQogICAg ICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAKQEAgLTMxNDIsMTEgKzMxNDIsNiBAQA0K ICAgICAgICAgaWYgKGJhc2VUYWJsZUNvbHVtbiA9PSB0b3RhbENvbHVtbnMpCiAgICAgICAgICAg ICBiYXNlVGFibGVDb2x1bW4gPSAwOwogCi0gICAgICAgIGlmIChyZXN1bHRTZXRNZXRhRGF0YV8u c3FseFJkYm5hbV9bYmFzZVRhYmxlQ29sdW1uXSAhPSBudWxsICYmCi0gICAgICAgICAgICAgICAg IXJlc3VsdFNldE1ldGFEYXRhXy5zcWx4UmRibmFtX1tiYXNlVGFibGVDb2x1bW5dLmVxdWFscygi IikpICAgICAgLy8gY2F0YWxvZwotICAgICAgICB7Ci0gICAgICAgICAgICB0YWJsZU5hbWUgKz0g IlwiIiArIHJlc3VsdFNldE1ldGFEYXRhXy5zcWx4UmRibmFtX1tiYXNlVGFibGVDb2x1bW5dICsg IlwiLiI7Ci0gICAgICAgIH0KICAgICAgICAgLy9kZXJ2aWVkIGNvbHVtbiBsaWtlIHNlbGVjdCAy IGZyb20gdDEsIGhhcyBudWxsIHNjaGVtYSBhbmQgdGFibGUgbmFtZQogICAgICAgICBpZiAocmVz dWx0U2V0TWV0YURhdGFfLnNxbHhTY2hlbWFfW2Jhc2VUYWJsZUNvbHVtbl0gIT0gbnVsbCAmJiAh cmVzdWx0U2V0TWV0YURhdGFfLnNxbHhTY2hlbWFfW2Jhc2VUYWJsZUNvbHVtbl0uZXF1YWxzKCIi KSkgewogICAgICAgICAgICAgdGFibGVOYW1lICs9ICJcIiIgKyByZXN1bHRTZXRNZXRhRGF0YV8u c3FseFNjaGVtYV9bYmFzZVRhYmxlQ29sdW1uXSArICJcIi4iOwo= ------=_Part_5479_16286303.1117900079389--