Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Derby Development" <derby-dev@db.apache.org>
Received-SPF: pass (hermes.apache.org: domain of m.v.lunteren@gmail.com
 designates 64.233.162.206 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:reply-to:to:subject:in-reply-to:mime-version:content-type:references;
        b=sniOu9PNxua0mgZaFMvo2qO6sfs1r6WmT2eP0QIvZ77OB83dOt7w6T020nthr+NEHhkZhBiMIAwJQlQ3NvsIkGR/7+TrJqDA5jLJ/7CPY0TSjZaCnsb7XDpR02fzneJzqemdujs50gLIKPJFFx2w2jcwGTZ+1BVvTBANyx4RNAk=
Message-ID: <c25576af0506091420723c8f2f@mail.gmail.com>
Date: Thu, 9 Jun 2005 14:20:39 -0700
From: Myrna van Lunteren <m.v.lunteren@gmail.com>
Reply-To: Myrna van Lunteren <m.v.lunteren@gmail.com>
To: Derby Development <derby-dev@db.apache.org>
Subject: Re: [PATCH] (DERBY-276) ResultSet.relative(int row) cannot be called
 when the cursor is not positioned on a row.
In-Reply-To: <c25576af050609141760c9b268@mail.gmail.com>
Mime-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_1202_13307247.1118352039008"
References: <20050527123139.GA30208@atum01.norway.sun.com>
	 <20050608213229.GA6409@barbar.sun.com>
	 <c25576af050609141760c9b268@mail.gmail.com>

------=_Part_1202_13307247.1118352039008
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Oh - maybe better to attach your next patch to the bug?
Myrna


 On 6/9/05, Myrna van Lunteren <m.v.lunteren@gmail.com> wrote:=20
>=20
> On 6/8/05, Bernt M. Johnsen <Bernt.Johnsen@sun.com> wrote:=20
> >=20
> > >>>>>>>>>>>> Bernt M. Johnsen wrote (2005-05-27 14:31:39):
> > > Could anybody review this?=20
> >=20
> > Well?
> >=20
> > > This patch will make relative() allowed when the cursor is before
> > > first or after last. It will also let absolute(0) be equivalent to
> > > beforeFirst().
> > [..snip..]
>=20
>   Well, well!=20
> I applied the patch without trouble (I feared it would be out of date=20
> already :-) ), built without trouble. It all looks reasonable to me.
> However, your patch doesn't include a modified master for scrollCursors2?
> Did you run derbyall?
>  Could this change create trouble for any existing applications? i.e. Wha=
t=20
> if someone has programmed an app to do relative(1) in a loop, breaking ou=
t=20
> when the exception is hit?
>  Thx,
> Myrna
>

------=_Part_1202_13307247.1118352039008
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

<div>Oh - maybe better to attach your next patch to the bug?</div>
<div>Myrna</div>
<div><br><br>&nbsp;</div>
<div><span class=3D"gmail_quote">On 6/9/05, <b class=3D"gmail_sendername">M=
yrna van Lunteren</b> &lt;<a href=3D"mailto:m.v.lunteren@gmail.com">m.v.lun=
teren@gmail.com</a>&gt; wrote:</span>
<blockquote class=3D"gmail_quote" style=3D"PADDING-LEFT: 1ex; MARGIN: 0px 0=
px 0px 0.8ex; BORDER-LEFT: #ccc 1px solid">
<div><span class=3D"q"><span class=3D"gmail_quote">On 6/8/05, <b class=3D"g=
mail_sendername">Bernt M. Johnsen</b> &lt;<a onclick=3D"return top.js.OpenE=
xtLink(window,event,this)" href=3D"mailto:Bernt.Johnsen@sun.com" target=3D"=
_blank">
Bernt.Johnsen@sun.com</a>&gt; wrote:</span> </span>
<blockquote class=3D"gmail_quote" style=3D"PADDING-LEFT: 1ex; MARGIN: 0px 0=
px 0px 0.8ex; BORDER-LEFT: #ccc 1px solid"><span class=3D"q">&gt;&gt;&gt;&g=
t;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt; Bernt M. Johnsen wrote (2005-05-27 14:31=
:39):
<br>&gt; Could anybody review this? <br><br>Well?<br><br>&gt; This patch wi=
ll make relative() allowed when the cursor is before<br>&gt; first or after=
 last. It will also let absolute(0) be equivalent to<br>&gt; beforeFirst().
<br></span>[..snip..]</blockquote>
<div>&nbsp;</div>
<div>&nbsp;</div>
<div>Well, well! </div>
<div>I applied the patch without trouble (I feared it would&nbsp;be out of =
date already :-) ), built without trouble. It all looks reasonable to me.</=
div>
<div>However, your patch doesn't include a modified master for scrollCursor=
s2?</div>
<div>Did you run derbyall?</div>
<div>&nbsp;</div>
<div>Could this change create trouble for any existing applications? i.e. W=
hat if someone has programmed an app to do relative(1) in a loop, breaking =
out when the exception is hit?</div>
<div>&nbsp;</div>
<div>Thx,</div>
<div>Myrna</div></div></blockquote></div><br>

------=_Part_1202_13307247.1118352039008--