Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 14702 invoked from network); 29 Jun 2005 17:43:12 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 29 Jun 2005 17:43:12 -0000 Received: (qmail 15724 invoked by uid 500); 29 Jun 2005 17:43:10 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 15691 invoked by uid 500); 29 Jun 2005 17:43:10 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: List-Id: Reply-To: "Derby Development" Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 15678 invoked by uid 99); 29 Jun 2005 17:43:10 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Jun 2005 10:43:10 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (asf.osuosl.org: local policy) Received: from [32.97.110.129] (HELO e31.co.us.ibm.com) (32.97.110.129) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Jun 2005 10:43:13 -0700 Received: from westrelay02.boulder.ibm.com (westrelay02.boulder.ibm.com [9.17.195.11]) by e31.co.us.ibm.com (8.12.10/8.12.9) with ESMTP id j5THh7iN259048 for ; Wed, 29 Jun 2005 13:43:07 -0400 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by westrelay02.boulder.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id j5THgodi255176 for ; Wed, 29 Jun 2005 11:43:06 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.12.11/8.13.3) with ESMTP id j5THge16014504 for ; Wed, 29 Jun 2005 11:42:40 -0600 Received: from [127.0.0.1] (sig-9-48-123-22.mts.ibm.com [9.48.123.22]) by d03av04.boulder.ibm.com (8.12.11/8.12.11) with ESMTP id j5THgcML014434 for ; Wed, 29 Jun 2005 11:42:39 -0600 Message-ID: <42C2DD8A.9040508@debrunners.com> Date: Wed, 29 Jun 2005 10:42:34 -0700 From: Daniel John Debrunner User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20040910 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Derby Development Subject: Re: [jira] Commented: (DERBY-31) Statement.setQueryTimeout() support. References: <144647292.1118655167897.JavaMail.jira@ajax.apache.org> <42B20A92.8030203@debrunners.com> <42BAA8D4.6090100@sun.com> <42BB3509.1010101@debrunners.com> In-Reply-To: <42BB3509.1010101@debrunners.com> X-Enigmail-Version: 0.90.0.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Daniel John Debrunner wrote: > Oyvind.Bakksjo@Sun.COM wrote: > > [on comments about re-use of TimerTasks] > write a comment about this in the code in a subsequent > >>patch (for instance when implementing Statement.cancel), unless anybody >>wants me to address this now and submit a new patch. > > > I think delaying the comment is fine. > > I'm planning to commit this change before the end of this week, assuming > all the tests run for me. I had to re-run the tests because the patch messed up on one file, but now StmtCloseFunTest fails for me with this patch. *** Start: StmtCloseFunTest jdk1.4.2 derbyall:jdbc20 2005-06-28 22:08:57 *** 2a3 > Statement Test failed (10) 4a6 > Prepared Statement Test failed 7a10 > Callable Statement Test failed Test Failed. *** End: StmtCloseFunTest jdk1.4.2 derbyall:jdbc20 2005-06-28 22:09:05 *** I'll look into it, but is anyone else seeing this failure? Dan.