Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 21049 invoked from network); 10 Jun 2005 23:50:54 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 10 Jun 2005 23:50:54 -0000 Received: (qmail 53371 invoked by uid 500); 10 Jun 2005 23:50:53 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 53347 invoked by uid 500); 10 Jun 2005 23:50:53 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: List-Id: Reply-To: "Derby Development" Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 53332 invoked by uid 99); 10 Jun 2005 23:50:53 -0000 X-ASF-Spam-Status: No, hits=0.4 required=10.0 tests=SPF_HELO_FAIL X-Spam-Check-By: apache.org Received-SPF: neutral (hermes.apache.org: local policy) Received: from over.ny.us.ibm.com (HELO over.ny.us.ibm.com) (32.97.182.150) by apache.org (qpsmtpd/0.28) with ESMTP; Fri, 10 Jun 2005 16:50:51 -0700 Received: from e4.ny.us.ibm.com ([192.168.1.104]) by pokfb.esmtp.ibm.com (8.12.11/8.12.11) with ESMTP id j5ALsnLp006523 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 10 Jun 2005 17:54:49 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e4.ny.us.ibm.com (8.12.11/8.12.11) with ESMTP id j5ALshL9015135 for ; Fri, 10 Jun 2005 17:54:43 -0400 Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay04.pok.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id j5ALsgAR209108 for ; Fri, 10 Jun 2005 17:54:43 -0400 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.12.11/8.13.3) with ESMTP id j5ALsgeH030758 for ; Fri, 10 Jun 2005 17:54:42 -0400 Received: from [127.0.0.1] (DMCSDJDT41P.svl.ibm.com [9.30.144.184]) by d01av03.pok.ibm.com (8.12.11/8.12.11) with ESMTP id j5ALsfgA030725 for ; Fri, 10 Jun 2005 17:54:42 -0400 Message-ID: <42AA0C21.5020603@debrunners.com> Date: Fri, 10 Jun 2005 14:54:41 -0700 From: Daniel John Debrunner User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20040910 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Derby Development Subject: Re: [jira] Commented: (DERBY-31) Statement.setQueryTimeout() support. References: <1520035658.1118402868355.JavaMail.jira@ajax.apache.org> In-Reply-To: <1520035658.1118402868355.JavaMail.jira@ajax.apache.org> X-Enigmail-Version: 0.90.0.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Oyvind Bakksjo (JIRA) wrote: > Here is an implementation of Statement.setQueryTimeout. > > The patch includes a new functional test in the jdbcapi testsuite. > > It is my first Derby patch, so I ask any reviewer; please, use your magnifying glass and be critical. :) > > May I suggest that Dan looks at it, since he has given me the most feedback on this issue? (I don't write this to exclude other volunteers, I just think that Mr. "Someone" already has enough on his todo list, given all the requests of the kind "Can someone review this patch?". ;o) I will look at it over this weekend. I think it missed the train for 10.1, but it could potentially go into a future 10.1 release (ie. on the branch) because it (I assume) is just runtime code, no upgrade or persistent issues. Dan.