Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 14915 invoked from network); 7 Jun 2005 15:01:25 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 7 Jun 2005 15:01:25 -0000 Received: (qmail 8180 invoked by uid 500); 7 Jun 2005 15:01:24 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 8117 invoked by uid 500); 7 Jun 2005 15:01:23 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: List-Id: Reply-To: "Derby Development" Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 8055 invoked by uid 99); 7 Jun 2005 15:01:23 -0000 X-ASF-Spam-Status: No, hits=2.2 required=10.0 tests=DNS_FROM_RFC_ABUSE,DNS_FROM_RFC_POST,SPF_HELO_FAIL X-Spam-Check-By: apache.org Received-SPF: neutral (hermes.apache.org: local policy) Received: from e33.co.us.ibm.com (HELO e33.co.us.ibm.com) (32.97.110.131) by apache.org (qpsmtpd/0.28) with ESMTP; Tue, 07 Jun 2005 08:01:19 -0700 Received: from westrelay02.boulder.ibm.com (westrelay02.boulder.ibm.com [9.17.195.11]) by e33.co.us.ibm.com (8.12.10/8.12.9) with ESMTP id j57F0QmD438488 for ; Tue, 7 Jun 2005 11:00:33 -0400 Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by westrelay02.boulder.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id j57F0P67220168 for ; Tue, 7 Jun 2005 09:00:26 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.12.11/8.13.3) with ESMTP id j57F0L2f029190 for ; Tue, 7 Jun 2005 09:00:21 -0600 Received: from [9.48.118.7] (sig-9-48-118-7.mts.ibm.com [9.48.118.7]) by d03av01.boulder.ibm.com (8.12.11/8.12.11) with ESMTP id j57F0KMO029006 for ; Tue, 7 Jun 2005 09:00:20 -0600 Message-ID: <42A5B6A2.2010702@sbcglobal.net> Date: Tue, 07 Jun 2005 08:00:50 -0700 From: Jack Klebanoff User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Derby Development Subject: Re: [PATCH] Referential Constraints References: <429DC906.10604@sbcglobal.net> <42A0DCDB.6050502@debrunners.com> In-Reply-To: <42A0DCDB.6050502@debrunners.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Daniel John Debrunner wrote: >Jack wrote: > >[snip] > > >>The patch changes iapi/sql/dictionary/DDUtils.java to remove the DDL time checks >> >> >[snip] > >I think all those checks need to remain for soft upgrade mode, otherwise >your changes allow referential actions to be created that will not be >handled correctly by 10.0 engines. > >The runtime code could probably remain as-is, in soft upgrade mode it >would just handle cases that wouldn't exist. So only the DDL code would >need checkVersion() calls. > > >Dan. > > > > I have modified my patch to incorporate Dan's request. The new patch looks at the database version and applies the V10.0 checks during referential constraint DDL if the database is V10.0 (soft upgrade). The new patch is attached to Derby-338 (http://issues.apache.org/jira/browse/DERBY-338). Jack