Once I applied both your patches, I found some problems. The problems
I applied the changes already. I think everything should be fine now.
Please look at my changes below. If they are incorrect, feel free to
send another patch. You can see the actual changes by: svn diff
- We needed to update dblook_test_net.out in both DerbyNet and
- Found a small problem in dblook itself. It was generating default
info for identity columns also, since toString() now returns
GENERATED_BY_DEFAULT string. dblook needed to be modified.
Transmitting file data ....
Committed revision 179708.
I have uploaded patch.
There found three error in result of derbyall.
I don't think they are caused by my modification...
I will execute derbyall again and confirm it.
----- Original Message ----- From: "Army" <email@example.com>
To: "Derby Development" <firstname.lastname@example.org>
Sent: Thursday, June 02, 2005 1:04 AM
Subject: Re: DERBY-318(Re: DERBY-308 just be done and .... (Re: [jira]
Updated: (DERBY-308) Modify dblook to support "GENERATED BY DEFAULT AS
I concluded as next.
Thinking "GENERATED BY DEFAULT AS IDENTITY" is a kind of default,
returning not null value for that column does not cause problem.
On the contrast , returning null value for column of "GENERATED BY
DEFAULT AS IDENTITY"
may cause some inconsistency, because the column is a column with
special default value.
Well, a GENERATED ALWAYS AS IDENTITY column is also "a column with
special default value", and yet Derby currently returns null for the
default of that kind of column. So to make GENERATED BY DEFAULT
columns match this behavior (by returning null) is, I think, the most
On the other hand, I agree that a non-null string such as
"GENERATED_BY_DEFAULT" has its benefits, as well. Since no one else
has commented one way or the other, and since I think we should get
this issue resolved sooner rather than later, I think you can go ahead
and do things the way you think is best.
So please feel free to make the change as you prefer, and to post the
patch to the list so we can proceed.
No virus found in this incoming message.
Checked by AVG Anti-Virus.
Version: 7.0.322 / Virus Database: 267.4.0 - Release Date: 2005/06/01