db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oystein.Grov...@Sun.COM (Øystein Grøvlen)
Subject Re: [jira] Updated: (DERBY-243) connection toString should uniquely identify the connection
Date Sun, 05 Jun 2005 21:47:09 GMT
>>>>> "DVC" == David Van Couvering <David.Vancouvering@Sun.COM> writes:

    DVC> Hi, Kathey. Nobody has tested this  patch. I think it's ready to go,
    DVC> but the last patch I did with  a full derbyall that then resulted in a
    DVC> bunch of  failures for Dan indicates  we really need  somebody else to
    DVC> review and test it.  So far no volunteers.

I have looked at the patch and it basically looks good.  I have a few
comments/questions:

    - 
    - Long lines
    - BrokeredConnection.toString(): Are you guranteed that
      getRealConnection never returns null?
    - CheckDataSource.checkNesConn():  Why have you changed it to
      throw Exception instead of SQLException?  Disables ...
    - Why print out?
    - Test that checks that they are equal

-- 
ystein


Mime
View raw message