db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mamta Satoor <msat...@gmail.com>
Subject Re: [PATCH] (Derby-331) create table fails when a constraint defintion follows a column default
Date Mon, 13 Jun 2005 18:15:30 GMT
Oh, just one minor thing. I think a comment in the code as to why we have 
(getToken(4).kind == LEFT_PAREN && getToken(2).kind != COMMA)} ) might help 
a future developer understand the code.
 thanks,
Mamta


 On 6/13/05, Mamta Satoor <msatoor@gmail.com> wrote: 
> 
> Hi Dag,
>  I looked at the patch and it looks good to me.
>  thanks,
> Mamta
> 
>  On 6/10/05, Dag H. Wanvik <Dag.Wanvik@sun.com> wrote: 
> > 
> > Hi,
> > 
> > I just uploaded a patch for this issue. Can somebody review it please?
> > It's small.
> > 
> > Dag 
> > 
> 
>

Mime
View raw message