db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mamta Satoor <msat...@gmail.com>
Subject Re: [PATCH] Updatable Resultset JDBC api (update and delete for forward only updatable resultsets) support for Network Server
Date Thu, 09 Jun 2005 06:56:15 GMT
Hi Satheesh,
 I did sync on couple of my clients and for some reason,
ResultSet.javastill shows the following deleted lines(these were
deleted as part of the
commit 189486. Do you or anyone else see these lines in your client?
- if (resultSetMetaData_.sqlxRdbnam_[baseTableColumn] != null &&
- !resultSetMetaData_.sqlxRdbnam_[baseTableColumn].equals("")) // catalog
- {
- tableName += "\"" + resultSetMetaData_.sqlxRdbnam_[baseTableColumn] + 
"\".";
- }
 thanks,
Mamta
 On 6/7/05, Satheesh Bandaram <satheesh@sourcery.org> wrote: 
> 
> Committed.
> 
> Sending java\client\org\apache\derby\client\am\ResultSet.java
> Transmitting file data .
> Committed revision 189486.
> [bandaram:satheesh]
> 
> Satheesh
> 
> Mamta Satoor wrote:
> 
>  Hi Satheesh,
>  I have a very small patch to address your review comments on Updatable 
> Resultset support for Network Server using Derby Net Client.
>  svn stat 
> M java\client\org\apache\derby\client\am\ResultSet.java
>  Please commit it if there are no issues.
>  thanks,
> Mamta
> 
>  On 5/23/05, Satheesh Bandaram <satheesh@sourcery.org> wrote: 
> > 
> > Some minor comments... Use them if they apply....
> > 
> > 
> >    1. Not sure if resultSetMetaData_.sqlxRdbnam_[baseTableColumn] is 
> >    ever set, so no need to check for that. 
> >    2. Use sqlxBasename_ instead of sqlxSchema_ when looking for a 
> >    valid base table. While both may work, it may be more readable. 
> > 
> > Satheesh
> > 
> >  ------------------------------
> 
> Index: java/client/org/apache/derby/client/am/ResultSet.java ===================================================================
> --- java/client/org/apache/derby/client/am/ResultSet.java (revision 179793) +++ java/client/org/apache/derby/client/am/ResultSet.java
(working copy) @@ -3134,7 +3134,7 @@ int baseTableColumn = 0; int totalColumns = resultSetMetaData_.getColumnCount();
>          for (; baseTableColumn < totalColumns; baseTableColumn++) {
> -            if (resultSetMetaData_.sqlxSchema_[baseTableColumn] != null)
> +            if (resultSetMetaData_.sqlxBasename_[baseTableColumn] != null)
>                  break;
>          }
>  
> @@ -3142,11 +3142,6 @@
>          if (baseTableColumn == totalColumns)
>              baseTableColumn = 0;
>  
> -        if (resultSetMetaData_.sqlxRdbnam_[baseTableColumn] != null &&
> -                !resultSetMetaData_.sqlxRdbnam_[baseTableColumn].equals(""))      //
catalog
> -        {
> -            tableName += "\"" + resultSetMetaData_.sqlxRdbnam_[baseTableColumn] + "\".";
> -        }
>          //dervied column like select 2 from t1, has null schema and table name
>          if (resultSetMetaData_.sqlxSchema_[baseTableColumn] != null && !resultSetMetaData_.sqlxSchema_[baseTableColumn].equals(""))
{
>              tableName += "\"" + resultSetMetaData_.sqlxSchema_[baseTableColumn] + "\".";
>   
> 
>

Mime
View raw message